)]}' { "commit": "6aea7624a01cc39c19d4237c4b108659270a61c5", "tree": "6f29a48e31675efb419783ae73ef86797f846f30", "parents": [ "402d2316c8a959dc011b5775970a6677edb20b17" ], "author": { "name": "Vijayenthiran Subramaniam", "email": "vijayenthiran.subramaniam@arm.com", "time": "Thu Sep 29 15:33:50 2022 +0530" }, "committer": { "name": "Vijayenthiran Subramaniam", "email": "vijayenthiran.subramaniam@arm.com", "time": "Tue Oct 11 21:17:47 2022 +0530" }, "message": "fix(gicv3/multichip): fix overflow caused by left shift\n\nWhen spi_id_max is 5119, the expression `(spi_id_max - 4096U + 1U \u003e\u003e 5)`\nevaluates to 32 leading to undefined behavior when using it to left\nshift 1. Fix this undefined behavior.\n\nReported-by coverity scan:\nhttps://lists.trustedfirmware.org/archives/list/tf-a@lists.trustedfirmware.org/thread/RMB4U7COL6IONZWEGF2FWXOQ6FPDIT4U/\n\n```\n large_shift: In expression 1 \u003c\u003c (spi_id_max - 4096U + 1U \u003e\u003e 5), left\n shifting by more than 31 bits has undefined behavior. The shift\n amount, spi_id_max - 4096U + 1U \u003e\u003e 5, is as much as 32.\n```\n\nSigned-off-by: Vijayenthiran Subramaniam \u003cvijayenthiran.subramaniam@arm.com\u003e\nChange-Id: I5e77a78b81a6d0367875e7ea432a82b6ba0e587c\n", "tree_diff": [ { "type": "modify", "old_id": "c7b15c1a6de9d0bb444e217c9888b13513b637b9", "old_mode": 33188, "old_path": "drivers/arm/gic/v3/gic600_multichip_private.h", "new_id": "414bd5b8496c183a4d509bad1ad1c23fb60925ab", "new_mode": 33188, "new_path": "drivers/arm/gic/v3/gic600_multichip_private.h" } ] }