refactor: factor Gerrit metadata generation into templates
Since the addition of the `expand_template` utility function to our Bash
utilities, we can expand Bash expressions in arbitrary files. In
particular, this allows us to generate YAML expressions within our LAVA
job templates, and begin reducing the amount of external script-based
templating we do.
This change begins with the Gerrit metadata section shared by both of
the FVP LAVA job templates, by removing the template-specific scripts
which generate the relevant YAML, and integrating it directly into the
templates.
Change-Id: I1e28791069e8194f967cb5b0df12a19db2a0f590
Signed-off-by: Chris Kay <chris.kay@arm.com>
diff --git a/script/lava-templates/fvp-linux.yaml b/script/lava-templates/fvp-linux.yaml
index 2f0527a..711499e 100644
--- a/script/lava-templates/fvp-linux.yaml
+++ b/script/lava-templates/fvp-linux.yaml
@@ -2,7 +2,12 @@
test_config: {TEST_CONFIG}
fvp_model: {MODEL}
build_url: ${BUILD_URL}
-${gerrit_meta}
+
+$(if [ -n "${gerrit_url}" ]; then
+ cat <<-YAML
+ gerrit_url: "${gerrit_url}"
+ YAML
+fi)
device_type: fvp
job_name: fvp-linux-{TEST_CONFIG}