commit 98c363dd404897301887fcfa7a0652742fbb8825
author Laurence Lundblade <laurencelundblade@users.noreply.github.com> Sun May 15 17:21:31 2022 -0700
committer GitHub <noreply@github.com> Sun May 15 17:21:31 2022 -0700
tree cb8b3148809bdaf68be67dde1e1c2c2a81619d9d
parent b24faef5fde27f2edc66f9e126c58af23cba3a2d

Fix compiler warnings in ub-example

Also make variable names consistent

Co-authored-by: Laurence Lundblade <lgl@securitytheory.com>

ub-example.c

diff --git a/ub-example.c b/ub-example.c
index 5c9b6f5..4c48d31 100644
--- a/ub-example.c
+++ b/ub-example.c
@@ -89,37 +89,37 @@
           const UsefulBuf    OutputBuffer,
           UsefulBufC        *Output)
 {
-    size_t nInputPosition;
-    size_t nOutputPosition;
+    size_t uInputPosition;
+    size_t uOutputPosition;
 
-    nOutputPosition = 0;
+    uOutputPosition = 0;
 
     /* Loop over all the bytes in Input */
-    for(nInputPosition = 0; nInputPosition < Input.len; nInputPosition++) {
-        const uint8_t nInputByte = ((uint8_t*)Input.ptr)[nInputPosition];
+    for(uInputPosition = 0; uInputPosition < Input.len; uInputPosition++) {
+        const uint8_t uInputByte = ((const uint8_t*)Input.ptr)[uInputPosition];
 
         /* Copy every byte */
         if(OutputBuffer.ptr != NULL) {
-            ((uint8_t *)OutputBuffer.ptr)[nOutputPosition] = nInputByte;
+            ((uint8_t *)OutputBuffer.ptr)[uOutputPosition] = uInputByte;
         }
-        nOutputPosition++;
-        if(nOutputPosition >= OutputBuffer.len) {
+        uOutputPosition++;
+        if(uOutputPosition >= OutputBuffer.len) {
             return -1;
         }
 
         /* Double output 'x' because that is what this contrived example does */
-        if(nInputByte== 'x') {
+        if(uInputByte== 'x') {
             if(OutputBuffer.ptr != NULL) {
-                ((uint8_t *)OutputBuffer.ptr)[nOutputPosition] = 'x';
+                ((uint8_t *)OutputBuffer.ptr)[uOutputPosition] = 'x';
             }
-            nOutputPosition++;
-            if(nOutputPosition >= OutputBuffer.len) {
+            uOutputPosition++;
+            if(uOutputPosition >= OutputBuffer.len) {
                 return -1;
             }
         }
     }
 
-    *Output = (UsefulBufC){OutputBuffer.ptr, nOutputPosition};
+    *Output = (UsefulBufC){OutputBuffer.ptr, uOutputPosition};
 
     return 0; /* success */
 }
@@ -133,37 +133,37 @@
                    const size_t    uOutputBufferLength,
                    size_t         *puOutputLength)
 {
-    size_t nInputPosition;
-    size_t nOutputPosition;
+    size_t uInputPosition;
+    size_t uOutputPosition;
 
-    nOutputPosition = 0;
+    uOutputPosition = 0;
 
     /* Loop over all the bytes in Input */
-    for(nInputPosition = 0; nInputPosition < uInputLength; nInputPosition++) {
-        const uint8_t nInputByte = ((uint8_t*)pInputPointer)[nInputPosition];
+    for(uInputPosition = 0; uInputPosition < uInputLength; uInputPosition++) {
+        const uint8_t uInputByte = ((const uint8_t*)pInputPointer)[uInputPosition];
 
         /* Copy every byte */
         if(pOutputBuffer != NULL) {
-            ((uint8_t *)pOutputBuffer)[nOutputPosition] = nInputByte;
+            ((uint8_t *)pOutputBuffer)[uOutputPosition] = uInputByte;
         }
-        nOutputPosition++;
-        if(nOutputPosition >= uOutputBufferLength) {
+        uOutputPosition++;
+        if(uOutputPosition >= uOutputBufferLength) {
             return -1;
         }
 
         /* Double output 'x' because that is what this contrived example does */
-        if(nInputByte== 'x') {
+        if(uInputByte== 'x') {
             if(pOutputBuffer != NULL) {
-                ((uint8_t *)pOutputBuffer)[nOutputPosition] = 'x';
+                ((uint8_t *)pOutputBuffer)[uOutputPosition] = 'x';
             }
-            nOutputPosition++;
-            if(nOutputPosition >= uOutputBufferLength) {
+            uOutputPosition++;
+            if(uOutputPosition >= uOutputBufferLength) {
                 return -1;
             }
         }
     }
 
-   *puOutputLength = nOutputPosition;
+   *puOutputLength = uOutputPosition;
 
     return 0; /* success */
 }