commit c5fef6875a8b85946593274df723f1c8cf9431be
author Laurence Lundblade <laurencelundblade@users.noreply.github.com> Sat Jan 25 11:38:45 2020 -0800
committer GitHub <noreply@github.com> Sat Jan 25 11:38:45 2020 -0800
tree b7f8cdc86ad39ebdf513d44fa3c22ab0bc610b70
parent ea627d280c754e2c5de21d97d78d1fdbe0de6901

Refine use of integer variables to quiet static analyzers and reduce object code size a little

Note that the no bugs of consequence were found by the static analyzer. The analyzer used was codesafe.cn

test/run_tests.c

diff --git a/test/run_tests.c b/test/run_tests.c
index 5b72398..133103f 100644
--- a/test/run_tests.c
+++ b/test/run_tests.c
@@ -24,7 +24,7 @@
  Test configuration
  */
 
-typedef int (test_fun_t)(void);
+typedef int32_t (test_fun_t)(void);
 typedef const char * (test_fun2_t)(void);
 
 
@@ -137,12 +137,12 @@
    }
 
    bool bDidSomeOutput = false;
-   for(int n = nMax; n > 0; n/=10) {
-      int x = nNum/n;
-      if(x || bDidSomeOutput){
+   for(int32_t n = nMax; n > 0; n/=10) {
+      int nDigitValue = nNum/n;
+      if(nDigitValue || bDidSomeOutput){
          bDidSomeOutput = true;
-         UsefulOutBuf_AppendByte(&OutBuf, '0' + x);
-         nNum -= x * n;
+         UsefulOutBuf_AppendByte(&OutBuf, (uint8_t)('0' + nDigitValue));
+         nNum -= nDigitValue * n;
       }
    }
    if(!bDidSomeOutput){
@@ -238,7 +238,7 @@
             }
         }
 
-        int nTestResult = (t->test_fun)();
+        int32_t nTestResult = (t->test_fun)();
         nTestsRun++;
         if(pfOutput) {
             (*pfOutput)(t->szTestName, poutCtx, 0);