commit 006c1b5f4e8dd2da632ddd5df97f1b5ec9163734
author Gilles Peskine <Gilles.Peskine@arm.com> Mon Sep 30 17:29:54 2019 +0200
committer Gilles Peskine <Gilles.Peskine@arm.com> Mon Sep 30 17:29:54 2019 +0200
tree b07ad4c6e36774f836269598f86cedf8a75b5858
parent 7edad280360df0c85d0d38c0d31074111c26e8fc

Prefer initializing ret to error values

These initial values shouldn't be used, but in case they accidentally
get used after a code change, fail safe.

library/hmac_drbg.c

diff --git a/library/hmac_drbg.c b/library/hmac_drbg.c
index edecc6e..67123df 100644
--- a/library/hmac_drbg.c
+++ b/library/hmac_drbg.c
@@ -74,7 +74,7 @@
     unsigned char rounds = ( additional != NULL && add_len != 0 ) ? 2 : 1;
     unsigned char sep[1];
     unsigned char K[MBEDTLS_MD_MAX_SIZE];
-    int ret = 0;
+    int ret = MBEDTLS_ERR_MD_BAD_INPUT_DATA;
 
     for( sep[0] = 0; sep[0] < rounds; sep[0]++ )
     {