commit f451bac0005fb7d4e3e335b824c87237b00148c3
author Paul Bakker <p.j.bakker@polarssl.org> Fri Aug 30 15:37:02 2013 +0200
committer Paul Bakker <p.j.bakker@polarssl.org> Fri Aug 30 15:48:53 2013 +0200
tree dfaa277ae1f3dc630b258e92ae5713db582ac58d
parent 48377d9834b9af17c89413801ba97ca3dd6ef930

Blinding RSA only active when f_rng is provided

library/rsa.c

diff --git a/library/rsa.c b/library/rsa.c
index da98336..c39a338 100644
--- a/library/rsa.c
+++ b/library/rsa.c
@@ -267,8 +267,6 @@
     mpi T, T1, T2;
     mpi A, X;
 
-    if( f_rng == NULL )
-        return( POLARSSL_ERR_RSA_BAD_INPUT_DATA );
 
     mpi_init( &T ); mpi_init( &T1 ); mpi_init( &T2 );
     mpi_init( &A ); mpi_init( &X );
@@ -283,15 +281,18 @@
 #if defined(POLARSSL_RSA_NO_CRT)
     MPI_CHK( mpi_exp_mod( &T, &T, &ctx->D, &ctx->N, &ctx->RN ) );
 #else
-    /*
-     * RSA Blinding
-     * A = rnd MPI
-     * T = A^E * T mod N
-     */
-    MPI_CHK( mpi_fill_random( &A, ctx->len - 1, f_rng, p_rng ) );
-    MPI_CHK( mpi_exp_mod( &X, &A, &ctx->E, &ctx->N, NULL ) );
-    MPI_CHK( mpi_mul_mpi( &X, &X, &T ) );
-    MPI_CHK( mpi_mod_mpi( &T, &X, &ctx->N ) );
+    if( f_rng != NULL )
+    {
+        /*
+         * RSA Blinding
+         * A = rnd MPI
+         * T = A^E * T mod N
+         */
+        MPI_CHK( mpi_fill_random( &A, ctx->len - 1, f_rng, p_rng ) );
+        MPI_CHK( mpi_exp_mod( &X, &A, &ctx->E, &ctx->N, NULL ) );
+        MPI_CHK( mpi_mul_mpi( &X, &X, &T ) );
+        MPI_CHK( mpi_mod_mpi( &T, &X, &ctx->N ) );
+    }
 
     /*
      * faster decryption using the CRT
@@ -310,18 +311,21 @@
     MPI_CHK( mpi_mod_mpi( &T, &T1, &ctx->P ) );
 
     /*
-     * X = T2 + T * Q
+     * T = T2 + T * Q
      */
     MPI_CHK( mpi_mul_mpi( &T1, &T, &ctx->Q ) );
-    MPI_CHK( mpi_add_mpi( &X, &T2, &T1 ) );
+    MPI_CHK( mpi_add_mpi( &T, &T2, &T1 ) );
 
-    /*
-     * Unblind
-     * T = X / A mod N
-     */
-    MPI_CHK( mpi_inv_mod( &A, &A, &ctx->N ) );
-    MPI_CHK( mpi_mul_mpi( &T, &X, &A ) );
-    MPI_CHK( mpi_mod_mpi( &T, &T, &ctx->N ) );
+    if( f_rng != NULL )
+    {
+        /*
+         * Unblind
+         * T = T / A mod N
+         */
+        MPI_CHK( mpi_inv_mod( &A, &A, &ctx->N ) );
+        MPI_CHK( mpi_mul_mpi( &T, &T, &A ) );
+        MPI_CHK( mpi_mod_mpi( &T, &T, &ctx->N ) );
+    }
 #endif
 
     olen = ctx->len;