commit 0024df6b3744844d8b6f8fac961ec6d55b1633fe
author Steven Cooreman <steven.cooreman@silabs.com> Mon Jul 13 10:59:40 2020 +0200
committer Steven Cooreman <steven.cooreman@silabs.com> Mon Jul 13 10:59:40 2020 +0200
tree 83951553030bf41e1c7f8833e408901d4bd04dc6
parent 14f0e526fb91b19ab147b7165c90141b8dde03b5

Remove superfluous argument to ecp_write_key

Removed after feedback from PR review.

Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com>

library/ecp.c

diff --git a/library/ecp.c b/library/ecp.c
index 94c7960..63e08df 100644
--- a/library/ecp.c
+++ b/library/ecp.c
@@ -2999,23 +2999,18 @@
 /*
  * Write a private key.
  */
-int mbedtls_ecp_write_key( mbedtls_ecp_group_id grp_id, mbedtls_ecp_keypair *key,
+int mbedtls_ecp_write_key( mbedtls_ecp_keypair *key,
                            unsigned char *buf, size_t buflen )
 {
-    int ret = 0;
+    int ret = MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
 
-    ECP_VALIDATE_RET( key  != NULL );
-    ECP_VALIDATE_RET( buf  != NULL );
-
-    if( ( ret = mbedtls_ecp_group_load( &key->grp, grp_id ) ) != 0 )
-        return( ret );
-
-    ret = MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
+    ECP_VALIDATE_RET( key != NULL );
+    ECP_VALIDATE_RET( buf != NULL );
 
 #if defined(ECP_MONTGOMERY)
     if( mbedtls_ecp_get_type( &key->grp ) == MBEDTLS_ECP_TYPE_MONTGOMERY )
     {
-        if( grp_id == MBEDTLS_ECP_DP_CURVE25519 )
+        if( key->grp.id == MBEDTLS_ECP_DP_CURVE25519 )
         {
             if( buflen < ECP_CURVE25519_KEY_SIZE )
                 return MBEDTLS_ERR_ECP_BUFFER_TOO_SMALL;

library/pkwrite.c

diff --git a/library/pkwrite.c b/library/pkwrite.c
index 4288cd7..ca5562a 100644
--- a/library/pkwrite.c
+++ b/library/pkwrite.c
@@ -168,7 +168,7 @@
     size_t byte_length = ( ec->grp.pbits + 7 ) / 8;
     unsigned char tmp[MBEDTLS_ECP_MAX_BYTES];
 
-    ret = mbedtls_ecp_write_key( ec->grp.id, ec, tmp, byte_length );
+    ret = mbedtls_ecp_write_key( ec, tmp, byte_length );
     if( ret != 0 )
         goto exit;
     ret = mbedtls_asn1_write_octet_string( p, start, tmp, byte_length );

library/psa_crypto.c

diff --git a/library/psa_crypto.c b/library/psa_crypto.c
index a620d30..b3da8f7 100644
--- a/library/psa_crypto.c
+++ b/library/psa_crypto.c
@@ -1326,8 +1326,8 @@
         if( bytes > data_size )
             return( PSA_ERROR_BUFFER_TOO_SMALL );
         status = mbedtls_to_psa_error(
-            mbedtls_ecp_write_key(slot->data.ecp->grp.id, slot->data.ecp,
-                                  data, bytes) );
+            mbedtls_ecp_write_key( slot->data.ecp,
+                                   data, bytes ) );
         if( status != PSA_SUCCESS )
             return( status );
         memset( data + bytes, 0, data_size - bytes );