commit 07f2c69511303ddc667756c0bb56c90d737573b4
author Gilles Peskine <Gilles.Peskine@arm.com> Wed Nov 16 19:48:23 2022 +0100
committer Janos Follath <janos.follath@arm.com> Tue Nov 22 21:22:53 2022 +0000
tree b0708019dc9b12d61085d9cdce72f6e6b7e16e21
parent 0ec6e3f3949713328e22f5cdfe300e5a7649c799

More consistent variable names

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>

library/bignum_core.c

diff --git a/library/bignum_core.c b/library/bignum_core.c
index 944b4be..957f190 100644
--- a/library/bignum_core.c
+++ b/library/bignum_core.c
@@ -608,7 +608,7 @@
     /* heap allocated memory pool */
     mbedtls_mpi_uint *mempool = NULL;
     /* pointers to temporaries within memory pool */
-    mbedtls_mpi_uint *Wtbl, *Wselect, *temp;
+    mbedtls_mpi_uint *Wtable, *Wselect, *temp;
     /* pointers to table entries */
     mbedtls_mpi_uint *Wcur, *Wlast, *W1;
 
@@ -624,8 +624,8 @@
     /* Allocate memory pool and set pointers to parts of it */
     const size_t table_limbs   = welem * AN_limbs;
     const size_t temp_limbs    = 2 * AN_limbs + 1;
-    const size_t wselect_limbs = AN_limbs;
-    const size_t total_limbs   = table_limbs + temp_limbs + wselect_limbs;
+    const size_t select_limbs  = AN_limbs;
+    const size_t total_limbs   = table_limbs + temp_limbs + select_limbs;
 
     mempool = mbedtls_calloc( total_limbs, sizeof(mbedtls_mpi_uint) );
     if( mempool == NULL )
@@ -634,19 +634,19 @@
         goto cleanup;
     }
 
-    Wtbl    = mempool;
-    Wselect = Wtbl    + table_limbs;
-    temp    = Wselect + wselect_limbs;
+    Wtable    = mempool;
+    Wselect = Wtable    + table_limbs;
+    temp    = Wselect  + select_limbs;
 
     /*
      * Window precomputation
      */
 
     /* W[0] = 1 (in Montgomery presentation) */
-    memset( Wtbl, 0, AN_limbs * ciL );
-    Wtbl[0] = 1;
-    mbedtls_mpi_core_montmul( Wtbl, Wtbl, RR, AN_limbs, N, AN_limbs, mm, temp );
-    Wcur = Wtbl + AN_limbs;
+    memset( Wtable, 0, AN_limbs * ciL );
+    Wtable[0] = 1;
+    mbedtls_mpi_core_montmul( Wtable, Wtable, RR, AN_limbs, N, AN_limbs, mm, temp );
+    Wcur = Wtable + AN_limbs;
     /* W[1] = A * R^2 * R^-1 mod N = A * R mod N */
     memcpy( Wcur, A, AN_limbs * ciL );
     mbedtls_mpi_core_montmul( Wcur, Wcur, RR, AN_limbs, N, AN_limbs, mm, temp );
@@ -662,7 +662,7 @@
      */
 
     /* X = 1 (in Montgomery presentation) initially */
-    memcpy( X, Wtbl, AN_limbs * ciL );
+    memcpy( X, Wtable, AN_limbs * ciL );
 
     size_t limb_bits_remaining = 0;
     mbedtls_mpi_uint cur_limb, window = 0;
@@ -682,7 +682,7 @@
             if( window_bits == 0 )
                 break;
             /* Select table entry, square and multiply */
-            mbedtls_mpi_core_ct_uint_table_lookup( Wselect, Wtbl,
+            mbedtls_mpi_core_ct_uint_table_lookup( Wselect, Wtable,
                                                    AN_limbs, welem, window );
             mbedtls_mpi_core_montmul( X, X, Wselect, AN_limbs, N, AN_limbs, mm, temp );
             window = window_bits = 0;