commit 08ad32721cb9a4e9916968e1876b7474ca2dba5d
author Jaeden Amero <jaeden.amero@arm.com> Mon Jan 14 13:12:39 2019 +0000
committer Jaeden Amero <jaeden.amero@arm.com> Tue Jan 15 11:29:19 2019 +0000
tree 647de5f8778a3c2c3f98a79bece1e88895d480fd
parent ec6ff863b50ff58ab626b18077f3b3eae91dba68

psa: Remove extra status handling from import

Remove extra status handling code from psa_import_key_into_slot(). This
helps save a tiny amount of code space, but mainly serves to improve the
readability of the code.

library/psa_crypto.c

diff --git a/library/psa_crypto.c b/library/psa_crypto.c
index 03d3371..bb53f81 100644
--- a/library/psa_crypto.c
+++ b/library/psa_crypto.c
@@ -701,8 +701,6 @@
         status = psa_import_ec_private_key( PSA_KEY_TYPE_GET_CURVE( slot->type ),
                                             data, data_length,
                                             &slot->data.ecp );
-        if( status != PSA_SUCCESS )
-            return( status );
     }
     else if( PSA_KEY_TYPE_IS_ECC_PUBLIC_KEY( slot->type ) )
     {
@@ -710,9 +708,6 @@
             PSA_KEY_TYPE_GET_CURVE( slot->type ),
             data, data_length,
             &slot->data.ecp );
-
-        if( status != PSA_SUCCESS )
-            return( status );
     }
     else
 #endif /* MBEDTLS_ECP_C */
@@ -722,16 +717,13 @@
         status = psa_import_rsa_key( slot->type,
             data, data_length,
             &slot->data.rsa );
-
-        if( status != PSA_SUCCESS )
-            return( status );
     }
     else
 #endif /* defined(MBEDTLS_RSA_C) && defined(MBEDTLS_PK_PARSE_C) */
     {
         return( PSA_ERROR_NOT_SUPPORTED );
     }
-    return( PSA_SUCCESS );
+    return( status );
 }
 
 /* Retrieve an empty key slot (slot with no key data, but possibly