commit 094a77e79c079bb8d8f1258013a8f2cf012eebc4
author Steven Cooreman <steven.cooreman@silabs.com> Thu May 06 17:58:36 2021 +0200
committer Steven Cooreman <steven.cooreman@silabs.com> Fri May 07 23:33:50 2021 +0200
tree c46a56b49983a3d1acaa1662ba6334f4aa2897e7
parent a6df6040eec06b4defb5dadb8f0be774d3fb34ec

Code flow and style improvements

Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com>

library/psa_crypto_mac.c

diff --git a/library/psa_crypto_mac.c b/library/psa_crypto_mac.c
index ca40b03..8e64741 100644
--- a/library/psa_crypto_mac.c
+++ b/library/psa_crypto_mac.c
@@ -200,20 +200,20 @@
                                 size_t key_buffer_size )
 {
     int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
-    const mbedtls_cipher_info_t * cipher_info_tmp =
+    const mbedtls_cipher_info_t * cipher_info =
         mbedtls_cipher_info_from_psa(
             PSA_ALG_CMAC,
             psa_get_key_type( attributes ),
             psa_get_key_bits( attributes ),
             NULL );
 
-    if( cipher_info_tmp == NULL )
+    if( cipher_info == NULL )
         return( PSA_ERROR_NOT_SUPPORTED );
 
     if( key_buffer_size < PSA_BITS_TO_BYTES( psa_get_key_bits( attributes ) ) )
         return( PSA_ERROR_INVALID_ARGUMENT );
 
-    ret = mbedtls_cipher_setup( &operation->ctx.cmac, cipher_info_tmp );
+    ret = mbedtls_cipher_setup( &operation->ctx.cmac, cipher_info );
     if( ret != 0 )
         goto exit;
 
@@ -319,15 +319,12 @@
 
     /* A context must be freshly initialized before it can be set up. */
     if( operation->alg != 0 )
-    {
         return( PSA_ERROR_BAD_STATE );
-    }
 
     status = mac_init( operation, alg );
     if( status != PSA_SUCCESS )
         return( status );
-    if( is_sign )
-        operation->is_sign = 1;
+    operation->is_sign = is_sign;
 
     /* Get the output length for the algorithm and key combination. None of the
      * currently supported algorithms have an output length dependent on actual
@@ -498,7 +495,7 @@
     size_t mac_size,
     size_t *mac_length )
 {
-    psa_status_t status;
+    psa_status_t status = PSA_ERROR_CORRUPTION_DETECTED;
 
     if( operation->alg == 0 )
         return( PSA_ERROR_BAD_STATE );
@@ -520,7 +517,7 @@
     size_t mac_length )
 {
     uint8_t actual_mac[PSA_MAC_MAX_SIZE];
-    psa_status_t status;
+    psa_status_t status = PSA_ERROR_CORRUPTION_DETECTED;
 
     if( operation->alg == 0 )
         return( PSA_ERROR_BAD_STATE );