commit 0be6aa9957e6b27f6256660f3bd032969f2c56f4
author makise-homura <akemi_homura@kurisa.ch> Tue Aug 18 23:52:53 2020 +0300
committer makise-homura <akemi_homura@kurisa.ch> Tue Aug 18 23:52:53 2020 +0300
tree e606dc2fde20dee28cc191c029acf3c495901916
parent ac2fd6524afdbaa42266b2c8c198eac7a7ca0a18

Get back -Wsign-compare and fix sources according to it

Signed-off-by: makise-homura <akemi_homura@kurisa.ch>

CMakeLists.txt

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 3fb4d36..d2cf446 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -179,10 +179,6 @@
     if(C_COMPILER_SUPPORTS_WSIGNED_ONE_BIT_FIELD)
         set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wno-signed-one-bit-field")
     endif()
-    CHECK_C_COMPILER_FLAG("-Wno-sign-compare" C_COMPILER_SUPPORTS_WSIGN_COMPARE)
-    if(C_COMPILER_SUPPORTS_WSIGN_COMPARE)
-        set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wno-sign-compare")
-    endif()
     set(CMAKE_C_FLAGS_RELEASE     "-O2")
     set(CMAKE_C_FLAGS_DEBUG       "-O0 -g3")
     set(CMAKE_C_FLAGS_COVERAGE    "-O0 -g3 --coverage")

library/ssl_msg.c

diff --git a/library/ssl_msg.c b/library/ssl_msg.c
index d32afac..259a71d 100644
--- a/library/ssl_msg.c
+++ b/library/ssl_msg.c
@@ -2048,7 +2048,7 @@
             if( ret < 0 )
                 return( ret );
 
-            if ( (size_t)ret > len || ( INT_MAX > SIZE_MAX && ret > SIZE_MAX ) )
+            if ( (size_t)ret > len || ( INT_MAX > SIZE_MAX && (size_t)ret > SIZE_MAX ) )
             {
                 MBEDTLS_SSL_DEBUG_MSG( 1,
                     ( "f_recv returned %d bytes but only %lu were requested",
@@ -2102,7 +2102,7 @@
         if( ret <= 0 )
             return( ret );
 
-        if( (size_t)ret > ssl->out_left || ( INT_MAX > SIZE_MAX && ret > SIZE_MAX ) )
+        if( (size_t)ret > ssl->out_left || ( INT_MAX > SIZE_MAX && (size_t)ret > SIZE_MAX ) )
         {
             MBEDTLS_SSL_DEBUG_MSG( 1,
                 ( "f_send returned %d bytes but only %lu bytes were sent",