Cleaned up location of init and free for some programs to prevent memory
leaks on incorrect arguments
diff --git a/programs/pkey/dh_client.c b/programs/pkey/dh_client.c
index 2d729df..66450b6 100644
--- a/programs/pkey/dh_client.c
+++ b/programs/pkey/dh_client.c
@@ -272,7 +272,9 @@
exit:
- net_close( server_fd );
+ if( server_fd != -1 )
+ net_close( server_fd );
+
rsa_free( &rsa );
dhm_free( &dhm );
entropy_free( &entropy );
diff --git a/programs/pkey/dh_genprime.c b/programs/pkey/dh_genprime.c
index 1f9d730..6d6e35a 100644
--- a/programs/pkey/dh_genprime.c
+++ b/programs/pkey/dh_genprime.c
@@ -65,6 +65,7 @@
((void) argv);
mpi_init( &G ); mpi_init( &P ); mpi_init( &Q );
+ entropy_init( &entropy );
if( ( ret = mpi_read_string( &G, 10, GENERATOR ) ) != 0 )
{
@@ -84,7 +85,6 @@
printf( "\n . Seeding the random number generator..." );
fflush( stdout );
- entropy_init( &entropy );
if( ( ret = ctr_drbg_init( &ctr_drbg, entropy_func, &entropy,
(const unsigned char *) pers,
strlen( pers ) ) ) != 0 )
diff --git a/programs/pkey/dh_server.c b/programs/pkey/dh_server.c
index 245f6f0..eb417da 100644
--- a/programs/pkey/dh_server.c
+++ b/programs/pkey/dh_server.c
@@ -273,7 +273,9 @@
exit:
- net_close( client_fd );
+ if( client_fd != -1 )
+ net_close( client_fd );
+
rsa_free( &rsa );
dhm_free( &dhm );
entropy_free( &entropy );
diff --git a/programs/pkey/gen_key.c b/programs/pkey/gen_key.c
index 9f060b7..43ae6e1 100644
--- a/programs/pkey/gen_key.c
+++ b/programs/pkey/gen_key.c
@@ -146,9 +146,12 @@
return( -1 );
if( fwrite( c, 1, len, f ) != len )
+ {
+ fclose( f );
return( -1 );
+ }
- fclose(f);
+ fclose( f );
return( 0 );
}
diff --git a/programs/pkey/key_app_writer.c b/programs/pkey/key_app_writer.c
index 4cf489b..269ddbd 100644
--- a/programs/pkey/key_app_writer.c
+++ b/programs/pkey/key_app_writer.c
@@ -104,9 +104,12 @@
return( -1 );
if( fwrite( c, 1, len, f ) != len )
+ {
+ fclose( f );
return( -1 );
+ }
- fclose(f);
+ fclose( f );
return( 0 );
}
@@ -140,9 +143,12 @@
return( -1 );
if( fwrite( c, 1, len, f ) != len )
+ {
+ fclose( f );
return( -1 );
+ }
- fclose(f);
+ fclose( f );
return( 0 );
}
diff --git a/programs/pkey/pk_sign.c b/programs/pkey/pk_sign.c
index 67ac0b4..4adb753 100644
--- a/programs/pkey/pk_sign.c
+++ b/programs/pkey/pk_sign.c
@@ -58,7 +58,7 @@
int main( int argc, char *argv[] )
{
FILE *f;
- int ret;
+ int ret = 1;
pk_context pk;
entropy_context entropy;
ctr_drbg_context ctr_drbg;
@@ -68,7 +68,8 @@
const char *pers = "pk_sign";
size_t olen = 0;
- ret = 1;
+ entropy_init( &entropy );
+ pk_init( &pk );
if( argc != 3 )
{
@@ -84,7 +85,6 @@
printf( "\n . Seeding the random number generator..." );
fflush( stdout );
- entropy_init( &entropy );
if( ( ret = ctr_drbg_init( &ctr_drbg, entropy_func, &entropy,
(const unsigned char *) pers,
strlen( pers ) ) ) != 0 )
@@ -96,8 +96,6 @@
printf( "\n . Reading private key from '%s'", argv[1] );
fflush( stdout );
- pk_init( &pk );
-
if( ( ret = pk_parse_keyfile( &pk, argv[1], "" ) ) != 0 )
{
ret = 1;
diff --git a/programs/pkey/pk_verify.c b/programs/pkey/pk_verify.c
index a188eb9..f2664a6 100644
--- a/programs/pkey/pk_verify.c
+++ b/programs/pkey/pk_verify.c
@@ -54,14 +54,15 @@
int main( int argc, char *argv[] )
{
FILE *f;
- int ret;
+ int ret = 1;
size_t i;
pk_context pk;
unsigned char hash[20];
unsigned char buf[POLARSSL_MPI_MAX_SIZE];
char filename[512];
- ret = 1;
+ pk_init( &pk );
+
if( argc != 3 )
{
printf( "usage: pk_verify <key_file> <filename>\n" );
@@ -76,8 +77,6 @@
printf( "\n . Reading public key from '%s'", argv[1] );
fflush( stdout );
- pk_init( &pk );
-
if( ( ret = pk_parse_public_keyfile( &pk, argv[1] ) ) != 0 )
{
printf( " failed\n ! pk_parse_public_keyfile returned -0x%04x\n", -ret );
diff --git a/programs/pkey/rsa_sign_pss.c b/programs/pkey/rsa_sign_pss.c
index 7e8ac4a..de33a6e 100644
--- a/programs/pkey/rsa_sign_pss.c
+++ b/programs/pkey/rsa_sign_pss.c
@@ -58,7 +58,7 @@
int main( int argc, char *argv[] )
{
FILE *f;
- int ret;
+ int ret = 1;
pk_context pk;
entropy_context entropy;
ctr_drbg_context ctr_drbg;
@@ -68,7 +68,8 @@
const char *pers = "rsa_sign_pss";
size_t olen = 0;
- ret = 1;
+ entropy_init( &entropy );
+ pk_init( &pk );
if( argc != 3 )
{
@@ -84,7 +85,6 @@
printf( "\n . Seeding the random number generator..." );
fflush( stdout );
- entropy_init( &entropy );
if( ( ret = ctr_drbg_init( &ctr_drbg, entropy_func, &entropy,
(const unsigned char *) pers,
strlen( pers ) ) ) != 0 )
@@ -96,8 +96,6 @@
printf( "\n . Reading private key from '%s'", argv[1] );
fflush( stdout );
- pk_init( &pk );
-
if( ( ret = pk_parse_keyfile( &pk, argv[1], "" ) ) != 0 )
{
ret = 1;
diff --git a/programs/pkey/rsa_verify_pss.c b/programs/pkey/rsa_verify_pss.c
index b41bcf8..0969a5a 100644
--- a/programs/pkey/rsa_verify_pss.c
+++ b/programs/pkey/rsa_verify_pss.c
@@ -55,14 +55,15 @@
int main( int argc, char *argv[] )
{
FILE *f;
- int ret;
+ int ret = 1;
size_t i;
pk_context pk;
unsigned char hash[20];
unsigned char buf[POLARSSL_MPI_MAX_SIZE];
char filename[512];
- ret = 1;
+ pk_init( &pk );
+
if( argc != 3 )
{
printf( "usage: rsa_verify_pss <key_file> <filename>\n" );
@@ -77,8 +78,6 @@
printf( "\n . Reading public key from '%s'", argv[1] );
fflush( stdout );
- pk_init( &pk );
-
if( ( ret = pk_parse_public_keyfile( &pk, argv[1] ) ) != 0 )
{
printf( " failed\n ! Could not read key from '%s'\n", argv[1] );