commit 109ee3de36453387aa107d89723ecabe44737836
author Kusumit Ghoderao <Kusumit.Ghoderao@silabs.com> Thu Jun 08 16:36:45 2023 +0530
committer Kusumit Ghoderao <Kusumit.Ghoderao@silabs.com> Thu Jun 08 16:36:45 2023 +0530
tree a61d0fc08e893460063e7c857f2301ad12243d9a
parent b821a5fd674fd91cd19fd46cd6965315c3aca01d

Use size of buffer for mac_size

Signed-off-by: Kusumit Ghoderao <Kusumit.Ghoderao@silabs.com>

library/psa_crypto.c

diff --git a/library/psa_crypto.c b/library/psa_crypto.c
index 8ea731b..baac97c 100644
--- a/library/psa_crypto.c
+++ b/library/psa_crypto.c
@@ -5527,26 +5527,21 @@
                                                 pbkdf2->password,
                                                 pbkdf2->password_length,
                                                 prf_alg, U_i, prf_output_length,
-                                                U_i, prf_output_length,
+                                                U_i, sizeof(U_i),
                                                 &mac_output_length);
         if (status != PSA_SUCCESS) {
             goto cleanup;
         }
 
-        // U1 xor U2
-        for (j = 0; j < prf_output_length; j++) {
-            U_accumulator[j] ^= U_i[j];
-        }
+        mbedtls_xor(U_accumulator, U_accumulator, U_i, prf_output_length);
     }
 
     memcpy(pbkdf2->output_block, U_accumulator, prf_output_length);
 
 cleanup:
     /* Zeroise buffers to clear sensitive data from memory. */
-    mbedtls_platform_zeroize(U_accumulator, PSA_HASH_MAX_SIZE);
-    mbedtls_platform_zeroize(U_i, PSA_HASH_MAX_SIZE);
-    mbedtls_platform_zeroize(input, pbkdf2->salt_length + 4);
-    mbedtls_free(input);
+    mbedtls_platform_zeroize(U_accumulator, PSA_MAC_MAX_SIZE);
+    mbedtls_platform_zeroize(U_i, PSA_MAC_MAX_SIZE); 
     return status;
 }