commit 116f50cd963b24534963c1bb0ffa788a43d6109a
author Leonid Rozenboim <leonid.rozenboim@oracle.com> Thu Apr 21 13:05:10 2022 -0700
committer Andrzej Kurek <andrzej.kurek@arm.com> Mon Jul 04 06:49:26 2022 -0400
tree 4d5473d952bef0444f25f66facc4aff3a6ebb4f5
parent 4d7af2aee098ed644cdb429139afc0ed7dd0e917

Fix resource leaks

These potential leaks were flagged by the Coverity static analyzer.

Signed-off-by: Leonid Rozenboim <leonid.rozenboim@oracle.com>

library/pkparse.c

diff --git a/library/pkparse.c b/library/pkparse.c
index 68727ec..bb5824f 100644
--- a/library/pkparse.c
+++ b/library/pkparse.c
@@ -1456,8 +1456,10 @@
         if( ( pk_info = mbedtls_pk_info_from_type( MBEDTLS_PK_RSA ) ) == NULL )
             return( MBEDTLS_ERR_PK_UNKNOWN_PK_ALG );
 
-        if( ( ret = mbedtls_pk_setup( ctx, pk_info ) ) != 0 )
+        if( ( ret = mbedtls_pk_setup( ctx, pk_info ) ) != 0 ) {
+            mbedtls_pem_free( &pem );
             return( ret );
+        }
 
         if ( ( ret = pk_get_rsapubkey( &p, p + pem.buflen, mbedtls_pk_rsa( *ctx ) ) ) != 0 )
             mbedtls_pk_free( ctx );

library/ssl_cache.c

diff --git a/library/ssl_cache.c b/library/ssl_cache.c
index fe4f30c..456f41c 100644
--- a/library/ssl_cache.c
+++ b/library/ssl_cache.c
@@ -312,7 +312,11 @@
 #endif
 
     if( session_serialized != NULL )
+    {
         mbedtls_platform_zeroize( session_serialized, session_serialized_len );
+        mbedtls_free(session_serialized);
+        session_serialized = NULL;
+    }
 
     return( ret );
 }