commit 15d7df2ba8ca706b944b771958cd23b6c2163f81
author Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com> Thu Aug 17 14:33:31 2017 +0200
committer Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com> Thu Aug 17 15:16:11 2017 +0200
tree 7e86a2190faf39c3858121405bdeabe5c5e5e6ad
parent 98a6778d478b62423bbb6ba85ec638e9f10b2374

Introduce mbedtls_pk_restart_ctx and use it

The fact that you needed to pass a pointer to mbedtls_ecdsa_restart_ctx (or
that you needed to know the key type of the PK context) was a breach of
abstraction.

Change the API (and callers) now, and the implementation will be changed in
the next commit.

tests/suites/test_suite_pk.function

diff --git a/tests/suites/test_suite_pk.function b/tests/suites/test_suite_pk.function
index 6e8c032..176b08f 100644
--- a/tests/suites/test_suite_pk.function
+++ b/tests/suites/test_suite_pk.function
@@ -127,12 +127,12 @@
     mbedtls_rsa_context *rsa;
     mbedtls_pk_context pk;
     int msg_len;
-    void *rs_ctx = NULL;
+    mbedtls_pk_restart_ctx *rs_ctx = NULL;
 #if defined(MBEDTLS_ECDSA_C) && defined(MBEDTLS_ECP_RESTARTABLE)
-    mbedtls_ecdsa_restart_ctx ctx;
+    mbedtls_pk_restart_ctx ctx;
 
     rs_ctx = &ctx;
-    mbedtls_ecdsa_restart_init( rs_ctx );
+    mbedtls_pk_restart_init( rs_ctx );
     mbedtls_ecp_set_max_ops( 42 );
 #endif
 
@@ -163,7 +163,7 @@
 
 exit:
 #if defined(MBEDTLS_ECDSA_C) && defined(MBEDTLS_ECP_RESTARTABLE)
-    mbedtls_ecdsa_restart_free( rs_ctx );
+    mbedtls_pk_restart_free( rs_ctx );
 #endif
     mbedtls_pk_free( &pk );
 }
@@ -274,7 +274,7 @@
                               int max_ops, int min_restart, int max_restart )
 {
     int ret, cnt_restart;
-    mbedtls_ecdsa_restart_ctx rs_ctx;
+    mbedtls_pk_restart_ctx rs_ctx;
     mbedtls_pk_context prv, pub;
     unsigned char hash[MBEDTLS_MD_MAX_SIZE];
     unsigned char sig[MBEDTLS_ECDSA_MAX_LEN];
@@ -282,7 +282,7 @@
     size_t hlen, slen, slen_check;
     const mbedtls_md_info_t *md_info;
 
-    mbedtls_ecdsa_restart_init( &rs_ctx );
+    mbedtls_pk_restart_init( &rs_ctx );
     mbedtls_pk_init( &prv );
     mbedtls_pk_init( &pub );
     memset( hash, 0, sizeof( hash ) );
@@ -351,7 +351,7 @@
     ret = mbedtls_pk_verify_restartable( &pub, md_alg,
                              hash, hlen, sig, slen, &rs_ctx );
     TEST_ASSERT( ret == 0 || ret == MBEDTLS_ERR_ECP_IN_PROGRESS );
-    mbedtls_ecdsa_restart_free( &rs_ctx );
+    mbedtls_pk_restart_free( &rs_ctx );
 
     slen = sizeof( sig );
     ret = mbedtls_pk_sign_restartable( &prv, md_alg, hash, hlen,
@@ -359,7 +359,7 @@
     TEST_ASSERT( ret == 0 || ret == MBEDTLS_ERR_ECP_IN_PROGRESS );
 
 exit:
-    mbedtls_ecdsa_restart_free( &rs_ctx );
+    mbedtls_pk_restart_free( &rs_ctx );
     mbedtls_pk_free( &prv );
     mbedtls_pk_free( &pub );
 }
@@ -373,10 +373,10 @@
     size_t sig_len;
     void *rs_ctx = NULL;
 #if defined(MBEDTLS_ECDSA_C) && defined(MBEDTLS_ECP_RESTARTABLE)
-    mbedtls_ecdsa_restart_ctx ctx;
+    mbedtls_pk_restart_ctx ctx;
 
     rs_ctx = &ctx;
-    mbedtls_ecdsa_restart_init( rs_ctx );
+    mbedtls_pk_restart_init( rs_ctx );
     mbedtls_ecp_set_max_ops( 42000 );
 #endif
 
@@ -429,7 +429,7 @@
 
 exit:
 #if defined(MBEDTLS_ECDSA_C) && defined(MBEDTLS_ECP_RESTARTABLE)
-    mbedtls_ecdsa_restart_free( rs_ctx );
+    mbedtls_pk_restart_free( rs_ctx );
 #endif
     mbedtls_pk_free( &pk );
 }