commit 1716f3286419bc68071d69db15daa5480c68df70
author Gilles Peskine <Gilles.Peskine@arm.com> Mon Sep 13 09:36:28 2021 +0200
committer Gilles Peskine <Gilles.Peskine@arm.com> Mon Sep 13 09:46:41 2021 +0200
tree f3b420e7dfa4bec58bb9f10127e36928c0efd8ce
parent 55dffe58a010298d81aa23832e2a3e4abb6d00f4

psa_cipher_update_ecb: remove parameter output_size

This parameter was set but not used, which was pointless. Clang 14 detects
this and legitimately complains.

Remove the parameter. This is an internal function, only called once. The
caller already has a sufficient check on the output buffer size which
applies in more cases, so there is no real gain in robustness in adding the
same check inside the internal function.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>

library/psa_crypto_cipher.c

diff --git a/library/psa_crypto_cipher.c b/library/psa_crypto_cipher.c
index f67b1ff..5c78c23 100644
--- a/library/psa_crypto_cipher.c
+++ b/library/psa_crypto_cipher.c
@@ -268,9 +268,8 @@
  *                      This does not need to be aligned to a block boundary.
  *                      If there is a partial block at the end of the input,
  *                      it is stored in \p ctx for future processing.
- * \param output        The buffer where the output is written.
- * \param output_size   The size of \p output in bytes.
- *                      It must be at least `floor((p + input_length) / BS)`
+ * \param output        The buffer where the output is written. Its size
+ *                      must be at least `floor((p + input_length) / BS)`
  *                      where `p` is the number of bytes in the unprocessed
  *                      partial block in \p ctx (`0 <= p <= BS - 1`) and
  *                      `BS` is the block size.
@@ -284,7 +283,6 @@
     const uint8_t *input,
     size_t input_length,
     uint8_t *output,
-    size_t output_size,
     size_t *output_length )
 {
     psa_status_t status = PSA_ERROR_CORRUPTION_DETECTED;
@@ -324,7 +322,6 @@
                 goto exit;
 
             output += internal_output_length;
-            output_size -= internal_output_length;
             *output_length += internal_output_length;
             ctx->unprocessed_len = 0;
         }
@@ -345,7 +342,6 @@
         input += block_size;
 
         output += internal_output_length;
-        output_size -= internal_output_length;
         *output_length += internal_output_length;
     }
 
@@ -400,7 +396,6 @@
                                         input,
                                         input_length,
                                         output,
-                                        output_size,
                                         output_length );
     }
     else