commit 1789d84282ac27136b00e30328f8a3f65c0edcf6
author Dave Rodgman <dave.rodgman@gmail.com> Mon May 29 22:05:19 2023 +0100
committer Dave Rodgman <dave.rodgman@arm.com> Wed Jun 07 16:50:15 2023 +0100
tree 167c9f88bc576ee014aa7a05778d0a0935bf56af
parent bcfd79c6992ac1dc79c34eeb75f1a623169f692b

remove not-needed fields from SHA-3 context

Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>

library/sha3.c

diff --git a/library/sha3.c b/library/sha3.c
index d875b81..b8abf9d 100644
--- a/library/sha3.c
+++ b/library/sha3.c
@@ -36,15 +36,17 @@
 #include "mbedtls/platform.h"
 #endif /* MBEDTLS_SELF_TEST */
 
+#define XOR_BYTE 0x6
+
 /*
  * List of supported SHA-3 families
  */
 static mbedtls_sha3_family_functions sha3_families[] = {
-    { MBEDTLS_SHA3_224,      1152, 224, 0x06 },
-    { MBEDTLS_SHA3_256,      1088, 256, 0x06 },
-    { MBEDTLS_SHA3_384,       832, 384, 0x06 },
-    { MBEDTLS_SHA3_512,       576, 512, 0x06 },
-    { MBEDTLS_SHA3_NONE, 0, 0, 0 }
+    { MBEDTLS_SHA3_224,      1152, 224 },
+    { MBEDTLS_SHA3_256,      1088, 256 },
+    { MBEDTLS_SHA3_384,       832, 384 },
+    { MBEDTLS_SHA3_512,       576, 512 },
+    { MBEDTLS_SHA3_NONE, 0, 0 }
 };
 
 static const uint64_t rc[24] = {
@@ -207,11 +209,8 @@
         return MBEDTLS_ERR_SHA3_BAD_INPUT_DATA;
     }
 
-    ctx->id = id;
-    ctx->r = p->r;
     ctx->olen = p->olen / 8;
-    ctx->xor_byte = p->xor_byte;
-    ctx->max_block_size = ctx->r / 8;
+    ctx->max_block_size = p->r / 8;
 
     memset(ctx->state, 0, sizeof(ctx->state));
     ctx->index = 0;
@@ -285,7 +284,7 @@
         olen = ctx->olen;
     }
 
-    ABSORB(ctx, ctx->index, ctx->xor_byte);
+    ABSORB(ctx, ctx->index, XOR_BYTE);
     ABSORB(ctx, ctx->max_block_size - 1, 0x80);
     keccak_f1600(ctx);
     ctx->index = 0;