commit 1bc59df92c4c82f284635bbb16fb1499e746c5df
author Paul Elliott <paul.elliott@arm.com> Sun Feb 05 13:41:57 2023 +0000
committer Paul Elliott <paul.elliott@arm.com> Wed Feb 15 23:34:29 2023 +0000
tree 99c1fd71de730b29f3672e80eb7a062b79995022
parent 096abc4dc0dd1cabf2f5f3350727e9b1b401c290

Rename curve_bytes to coordinate_bytes

Also remove unneeded instance from verify operation struct.

Signed-off-by: Paul Elliott <paul.elliott@arm.com>

library/psa_crypto.c

diff --git a/library/psa_crypto.c b/library/psa_crypto.c
index 2797291..dcc6ab8 100644
--- a/library/psa_crypto.c
+++ b/library/psa_crypto.c
@@ -3509,7 +3509,7 @@
 
     mbedtls_ecdsa_restart_init(&operation->restart_ctx);
 
-    operation->curve_bytes = PSA_BITS_TO_BYTES(
+    operation->coordinate_bytes = PSA_BITS_TO_BYTES(
         operation->ctx->grp.pbits);
 
     psa_algorithm_t hash_alg = PSA_ALG_SIGN_GET_HASH(alg);
@@ -3549,7 +3549,7 @@
     defined(MBEDTLS_PSA_BUILTIN_ALG_DETERMINISTIC_ECDSA)) && \
     defined(MBEDTLS_ECP_RESTARTABLE)
 
-    if (signature_size < 2 * operation->curve_bytes) {
+    if (signature_size < 2 * operation->coordinate_bytes) {
         return PSA_ERROR_BUFFER_TOO_SMALL;
     }
 
@@ -3595,7 +3595,8 @@
         status =  mbedtls_to_psa_error(
             mbedtls_mpi_write_binary(&r,
                                      signature,
-                                     operation->curve_bytes));
+                                     operation->coordinate_bytes)
+            );
 
         if (status != PSA_SUCCESS) {
             return status;
@@ -3604,14 +3605,15 @@
         status =  mbedtls_to_psa_error(
             mbedtls_mpi_write_binary(&s,
                                      signature +
-                                     operation->curve_bytes,
-                                     operation->curve_bytes));
+                                     operation->coordinate_bytes,
+                                     operation->coordinate_bytes)
+            );
 
         if (status != PSA_SUCCESS) {
             return status;
         }
 
-        *signature_length = operation->curve_bytes * 2;
+        *signature_length = operation->coordinate_bytes * 2;
 
         return PSA_SUCCESS;
     }
@@ -3667,6 +3669,7 @@
     const uint8_t *signature, size_t signature_length)
 {
     psa_status_t status = PSA_ERROR_CORRUPTION_DETECTED;
+    size_t coordinate_bytes = 0;
 
     if (!PSA_KEY_TYPE_IS_ECC(attributes->core.type)) {
         return PSA_ERROR_NOT_SUPPORTED;
@@ -3695,11 +3698,9 @@
         return status;
     }
 
-    operation->curve_bytes = PSA_BITS_TO_BYTES(
-        operation->ctx->grp.pbits);
+    coordinate_bytes = PSA_BITS_TO_BYTES(operation->ctx->grp.pbits);
 
-
-    if (signature_length != 2 * operation->curve_bytes) {
+    if (signature_length != 2 * coordinate_bytes) {
         return PSA_ERROR_INVALID_SIGNATURE;
     }
 
@@ -3707,7 +3708,7 @@
     status = mbedtls_to_psa_error(
         mbedtls_mpi_read_binary(&operation->r,
                                 signature,
-                                operation->curve_bytes));
+                                coordinate_bytes));
 
     if (status != PSA_SUCCESS) {
         return status;
@@ -3717,8 +3718,8 @@
     status = mbedtls_to_psa_error(
         mbedtls_mpi_read_binary(&operation->s,
                                 signature +
-                                operation->curve_bytes,
-                                operation->curve_bytes));
+                                coordinate_bytes,
+                                coordinate_bytes));
 
     if (status != PSA_SUCCESS) {
         return status;