commit 1c4eaa121f3da33ea76d22f059c71d2321d9291e
author Dave Rodgman <dave.rodgman@arm.com> Wed May 17 12:22:59 2023 +0100
committer Dave Rodgman <dave.rodgman@arm.com> Fri May 26 12:42:48 2023 +0100
tree 68ec5f7052730fdd8f36315fb0a28fbc213ab1da
parent 74e18ebf7784746358255c51916699be9004d9c1

Remove not-needed compiler_opaque in ct_if

Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>

library/constant_time_impl.h

diff --git a/library/constant_time_impl.h b/library/constant_time_impl.h
index f4ad115..149cf75 100644
--- a/library/constant_time_impl.h
+++ b/library/constant_time_impl.h
@@ -111,11 +111,9 @@
                                               mbedtls_ct_uint_t if1,
                                               mbedtls_ct_uint_t if0)
 {
-    mbedtls_ct_condition_t not_mask =
+    mbedtls_ct_condition_t not_cond =
         (mbedtls_ct_condition_t) (~mbedtls_ct_compiler_opaque(condition));
-    mbedtls_ct_condition_t mask     =
-        (mbedtls_ct_condition_t)   mbedtls_ct_compiler_opaque(condition);
-    return (mbedtls_ct_uint_t) ((mask & if1) | (not_mask & if0));
+    return (mbedtls_ct_uint_t) ((condition & if1) | (not_cond & if0));
 }
 
 static inline mbedtls_ct_condition_t mbedtls_ct_bool_lt(mbedtls_ct_uint_t x, mbedtls_ct_uint_t y)