commit 216baca1314b04c77034379210291f900156c1bc
author Andrzej Kurek <Andrzej.Kurek@arm.com> Thu Sep 01 12:59:05 2022 -0400
committer Andrzej Kurek <Andrzej.Kurek@arm.com> Fri Sep 02 04:15:34 2022 -0400
tree acc4a5af887231f8a115bd4a145ce4211d166cdd
parent e3d544c58f895eff886c90562232ee3e5c5be370

pkcs5: improve error handling

Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>

library/pkcs5.c

diff --git a/library/pkcs5.c b/library/pkcs5.c
index 9394181..847496d 100644
--- a/library/pkcs5.c
+++ b/library/pkcs5.c
@@ -329,7 +329,6 @@
     mbedtls_md_free( &md_ctx );
     return( ret );
 #else
-    int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
     int j;
     unsigned int i;
     unsigned char md1[PSA_HASH_MAX_SIZE];
@@ -338,6 +337,7 @@
     psa_mac_operation_t operation = PSA_MAC_OPERATION_INIT;
 
     psa_status_t status = PSA_ERROR_CORRUPTION_DETECTED;
+    psa_status_t status_destruction = PSA_ERROR_CORRUPTION_DETECTED;
     size_t use_len, out_len;
     unsigned char *out_p = output;
     unsigned char counter[4];
@@ -359,7 +359,7 @@
                                    password, plen,
                                    &psa_hmac_key ) ) != PSA_SUCCESS )
     {
-        return MBEDTLS_ERR_ERROR_GENERIC_ERROR;
+        return MBEDTLS_ERR_PKCS5_BAD_INPUT_DATA;
     }
 
 #if UINT_MAX > 0xFFFFFFFF
@@ -396,11 +396,9 @@
                 goto cleanup;
             if( ( status = psa_mac_update( &operation, md1, md_size ) ) != PSA_SUCCESS )
                 goto cleanup;
-
             if( ( status = psa_mac_sign_finish( &operation, md1, out_size, &out_len ) ) != PSA_SUCCESS )
                 goto cleanup;
 
-
             // U1 xor U2
             //
             for( j = 0; j < md_size; j++ )
@@ -422,13 +420,14 @@
     /* Zeroise buffers to clear sensitive data from memory. */
     mbedtls_platform_zeroize( work, PSA_HASH_MAX_SIZE );
     mbedtls_platform_zeroize( md1, PSA_HASH_MAX_SIZE );
-    psa_destroy_key( psa_hmac_key );
-    ret = (status != PSA_SUCCESS? MBEDTLS_ERR_ERROR_GENERIC_ERROR: 0);
-    status = psa_mac_abort( &operation );
-    if( ret == 0 && status != PSA_SUCCESS )
-        ret = MBEDTLS_ERR_ERROR_GENERIC_ERROR;
+    status_destruction = psa_destroy_key( psa_hmac_key );
+    if( status == PSA_SUCCESS && status_destruction != PSA_SUCCESS )
+        status = status_destruction;
+    status_destruction = psa_mac_abort( &operation );
+    if( status == PSA_SUCCESS && status_destruction != PSA_SUCCESS )
+        status = status_destruction;
 
-    return ( ret );
+    return( mbedtls_md_error_from_psa( status ) );
 #endif /* !MBEDTLS_MD_C */
 }