commit 2262648b6968f4dee34f4437dbfb9f30cdc0de45
author Hanno Becker <hanno.becker@arm.com> Fri May 03 12:46:59 2019 +0100
committer Hanno Becker <hanno.becker@arm.com> Mon Jun 03 14:43:16 2019 +0100
tree 556bd17608f98e21e8425529caade066e96c81b9
parent 08556bf8fb6a81a001b2ae9e016ca0df8b82163e

Improve debugging output of client-side CID extension parsing

library/ssl_cli.c

diff --git a/library/ssl_cli.c b/library/ssl_cli.c
index 529a80b..1063f45 100644
--- a/library/ssl_cli.c
+++ b/library/ssl_cli.c
@@ -1305,13 +1305,19 @@
     if( /* CID extension only makes sense in DTLS */
         ssl->conf->transport != MBEDTLS_SSL_TRANSPORT_DATAGRAM ||
         /* The server must only send the CID extension if we have offered it. */
-        ssl->negotiate_cid == MBEDTLS_SSL_CID_DISABLED ||
-        /* CID extension must at least contain the length byte */
-        len < 1 )
+        ssl->negotiate_cid == MBEDTLS_SSL_CID_DISABLED )
     {
-        MBEDTLS_SSL_DEBUG_MSG( 1, ( "non-matching CID extension" ) );
+        MBEDTLS_SSL_DEBUG_MSG( 1, ( "CID extension unexpected" ) );
         mbedtls_ssl_send_alert_message( ssl, MBEDTLS_SSL_ALERT_LEVEL_FATAL,
-                                        MBEDTLS_SSL_ALERT_MSG_HANDSHAKE_FAILURE );
+                                     MBEDTLS_SSL_ALERT_MSG_HANDSHAKE_FAILURE );
+        return( MBEDTLS_ERR_SSL_BAD_HS_SERVER_HELLO );
+    }
+
+    if( len == 0 )
+    {
+        MBEDTLS_SSL_DEBUG_MSG( 1, ( "CID extension invalid" ) );
+        mbedtls_ssl_send_alert_message( ssl, MBEDTLS_SSL_ALERT_LEVEL_FATAL,
+                                     MBEDTLS_SSL_ALERT_MSG_HANDSHAKE_FAILURE );
         return( MBEDTLS_ERR_SSL_BAD_HS_SERVER_HELLO );
     }
 
@@ -1320,17 +1326,17 @@
 
     if( peer_cid_len > MBEDTLS_SSL_CID_OUT_LEN_MAX )
     {
-        MBEDTLS_SSL_DEBUG_MSG( 1, ( "non-matching CID extension" ) );
+        MBEDTLS_SSL_DEBUG_MSG( 1, ( "CID extension invalid" ) );
         mbedtls_ssl_send_alert_message( ssl, MBEDTLS_SSL_ALERT_LEVEL_FATAL,
-                                        MBEDTLS_SSL_ALERT_MSG_HANDSHAKE_FAILURE );
+                                     MBEDTLS_SSL_ALERT_MSG_HANDSHAKE_FAILURE );
         return( MBEDTLS_ERR_SSL_BAD_HS_SERVER_HELLO );
     }
 
     if( len != peer_cid_len )
     {
-        MBEDTLS_SSL_DEBUG_MSG( 1, ( "non-matching CID extension" ) );
+        MBEDTLS_SSL_DEBUG_MSG( 1, ( "CID extension invalid" ) );
         mbedtls_ssl_send_alert_message( ssl, MBEDTLS_SSL_ALERT_LEVEL_FATAL,
-                                        MBEDTLS_SSL_ALERT_MSG_ILLEGAL_PARAMETER );
+                                     MBEDTLS_SSL_ALERT_MSG_ILLEGAL_PARAMETER );
         return( MBEDTLS_ERR_SSL_BAD_HS_SERVER_HELLO );
     }