commit 258bab0b1b31f0da623a74f7fa6f4fe9468cbd34
author Manuel Pégourié-Gonnard <mpg@elzevir.fr> Tue Nov 25 17:41:50 2014 +0100
committer Manuel Pégourié-Gonnard <mpg@elzevir.fr> Thu Nov 27 09:27:21 2014 +0100
tree 679c9f461fbad99e11f232a13bb777575dc8ea3d
parent aa02dc1ed80ad3f48f40fcf17e15b243fdba51ce

Fix missing bound check

library/ctr_drbg.c

diff --git a/library/ctr_drbg.c b/library/ctr_drbg.c
index 1b46f45..980d954 100644
--- a/library/ctr_drbg.c
+++ b/library/ctr_drbg.c
@@ -118,6 +118,9 @@
 
     int i, j, buf_len, use_len;
 
+    if( data_len > CTR_DRBG_MAX_SEED_INPUT )
+        return( POLARSSL_ERR_CTR_DRBG_INPUT_TOO_BIG );
+
     memset( buf, 0, CTR_DRBG_MAX_SEED_INPUT + CTR_DRBG_BLOCKSIZE + 16 );
 
     /*
@@ -233,6 +236,11 @@
 
     if( add_len > 0 )
     {
+        /* MAX_INPUT would be more logical here, but we have to match
+         * block_cipher_df()'s limits since we can't propagate errors */
+        if( add_len > CTR_DRBG_MAX_SEED_INPUT )
+            add_len = CTR_DRBG_MAX_SEED_INPUT;
+
         block_cipher_df( add_input, additional, add_len );
         ctr_drbg_update_internal( ctx, add_input );
     }