commit 28a45ed8dbc8ad706ce76c1e7ad735b6396f8059
author Ronald Cron <ronald.cron@arm.com> Tue Feb 09 20:35:42 2021 +0100
committer Ronald Cron <ronald.cron@arm.com> Wed Feb 10 16:07:21 2021 +0100
tree d1fe048983e2e5bb22ce4ab34127114a94b186d5
parent 50f1f5e119c157425d9a147a74216cbf9faef8e8

tests: psa: Add macros to skip a test case

Add macros to skip a test case when hitting a
common alternative implementation limitation.

Add a macro for AES-192 and GCM with a nonce
length different from 12 bytes.

Signed-off-by: Ronald Cron <ronald.cron@arm.com>

tests/suites/test_suite_psa_crypto.function

diff --git a/tests/suites/test_suite_psa_crypto.function b/tests/suites/test_suite_psa_crypto.function
index b68eb7c..dbcdb3f 100644
--- a/tests/suites/test_suite_psa_crypto.function
+++ b/tests/suites/test_suite_psa_crypto.function
@@ -12,6 +12,8 @@
 #include "psa/crypto.h"
 #include "psa_crypto_slot_management.h"
 
+#include "test/psa_crypto_helpers.h"
+
 /** An invalid export length that will never be set by psa_export_key(). */
 static const size_t INVALID_EXPORT_LENGTH = ~0U;
 
@@ -4093,28 +4095,14 @@
                                output_data, output_size,
                                &output_length );
 
-#if defined(MBEDTLS_AES_ALT) || \
-    defined(MBEDTLS_AES_SETKEY_ENC_ALT) || \
-    defined(MBEDTLS_PSA_ACCEL_KEY_TYPE_AES)
-    if( status == PSA_ERROR_NOT_SUPPORTED &&
-        key_type == PSA_KEY_TYPE_AES &&
-        key_data->len == 24 )
+    /* If the operation is not supported, just skip and not fail in case the
+     * encryption involves a common limitation of cryptography hardwares and
+     * an alternative implementation. */
+    if( status == PSA_ERROR_NOT_SUPPORTED )
     {
-        test_skip( "AES-192 not supported", __LINE__, __FILE__ );
-        goto exit;
+        MBEDTLS_TEST_PSA_SKIP_IF_ALT_AES_192( key_type, key_data->len * 8 );
+        MBEDTLS_TEST_PSA_SKIP_IF_ALT_GCM_NOT_12BYTES_NONCE( alg, nonce->len );
     }
-#endif /* AES could be alternatively implemented */
-#if defined(MBEDTLS_GCM_ALT) || \
-    defined(MBEDTLS_PSA_ACCEL_ALG_GCM)
-    if( status == PSA_ERROR_NOT_SUPPORTED &&
-        ( PSA_ALG_AEAD_WITH_TAG_LENGTH( alg, 0 ) ==
-          PSA_ALG_AEAD_WITH_TAG_LENGTH( PSA_ALG_GCM, 0 ) ) &&
-        nonce->len != 12 )
-    {
-        test_skip( "AES-GCM with non-12-byte IV is not supported", __LINE__, __FILE__ );
-        goto exit;
-    }
-#endif /* AES-GCM could be alternatively implemented */
 
     PSA_ASSERT( status );
     ASSERT_COMPARE( expected_result->x, expected_result->len,
@@ -4172,28 +4160,14 @@
                                output_data, output_size,
                                &output_length );
 
-#if defined(MBEDTLS_AES_ALT) || \
-    defined(MBEDTLS_AES_SETKEY_ENC_ALT) || \
-    defined(MBEDTLS_PSA_ACCEL_KEY_TYPE_AES)
-    if( status == PSA_ERROR_NOT_SUPPORTED &&
-        key_type == PSA_KEY_TYPE_AES &&
-        key_data->len == 24 )
+    /* If the operation is not supported, just skip and not fail in case the
+     * decryption involves a common limitation of cryptography hardwares and
+     * an alternative implementation. */
+    if( status == PSA_ERROR_NOT_SUPPORTED )
     {
-        test_skip( "AES-192 not supported", __LINE__, __FILE__ );
-        goto exit;
+        MBEDTLS_TEST_PSA_SKIP_IF_ALT_AES_192( key_type, key_data->len * 8 );
+        MBEDTLS_TEST_PSA_SKIP_IF_ALT_GCM_NOT_12BYTES_NONCE( alg, nonce->len );
     }
-#endif /* AES could be alternatively implemented */
-#if defined(MBEDTLS_GCM_ALT) || \
-    defined(MBEDTLS_PSA_ACCEL_ALG_GCM)
-    if( status == PSA_ERROR_NOT_SUPPORTED &&
-        ( PSA_ALG_AEAD_WITH_TAG_LENGTH( alg, 0 ) ==
-          PSA_ALG_AEAD_WITH_TAG_LENGTH( PSA_ALG_GCM, 0 ) ) &&
-        nonce->len != 12 )
-    {
-        test_skip( "AES-GCM with non-12-byte IV is not supported", __LINE__, __FILE__ );
-        goto exit;
-    }
-#endif /* AES-GCM could be alternatively implemented */
 
     TEST_EQUAL( status, expected_result );