commit 28d162829b2a136f9e57b9b260ea2f43315fb597
author Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com> Wed Aug 23 17:33:27 2017 +0200
committer Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com> Wed Aug 23 18:20:17 2017 +0200
tree 73150f1b4b7184a8151408911e7b2a82361d16d3
parent 5bd38b1144420d234c4411914433ff31256e9168

Avoid unnecessary xxx_copy() calls

The call would anyway check for pointer equality and return early, but it
doesn't hurt to save a function call, and also this follows more uniformly the
pattern that those two lines go together:

    #if defined(MBEDTLS_ECP_RESTARTBLE)
    if( rs_ctx != NULL && ...

library/ecdsa.c

diff --git a/library/ecdsa.c b/library/ecdsa.c
index f3b3cf2..835d3de 100644
--- a/library/ecdsa.c
+++ b/library/ecdsa.c
@@ -353,7 +353,8 @@
     while( mbedtls_mpi_cmp_int( s, 0 ) == 0 );
 
 #if defined(MBEDTLS_ECP_RESTARTABLE)
-    mbedtls_mpi_copy( r, pr );
+    if( rs_ctx != NULL && rs_ctx->sig != NULL )
+        mbedtls_mpi_copy( r, pr );
 #endif
 
 cleanup: