commit 2cfa5072ed4a00ed1e64fed5f3a00b63ca62ebc3
author Brian Murray <Brian@Clover.com> Mon May 23 20:17:04 2016 -0700
committer Simon Butcher <simon.butcher@arm.com> Wed Oct 05 14:19:16 2016 +0100
tree 5a3d5e595f2e7a1a5ae5c9d512d1c964914874eb
parent 57863ad7edafcbb137ee37a8d09243e7b734462d

better handling of failed calloc

library/cmac.c

diff --git a/library/cmac.c b/library/cmac.c
index 39ebb87..4c25a67 100644
--- a/library/cmac.c
+++ b/library/cmac.c
@@ -173,12 +173,6 @@
     if( cipher_info == NULL )
         return( MBEDTLS_ERR_CMAC_BAD_INPUT );
 
-    ctx->K1 = mbedtls_calloc( cipher_info->block_size, sizeof( unsigned char ) );
-    ctx->K2 = mbedtls_calloc( cipher_info->block_size, sizeof( unsigned char ) );
-
-    if(ctx->K1 == NULL || ctx->K2 == NULL )
-        return MBEDTLS_ERR_CMAC_ALLOC_FAILED;
-
     mbedtls_cipher_free( &ctx->cipher_ctx );
 
     if( ( ret = mbedtls_cipher_setup( &ctx->cipher_ctx, cipher_info ) ) != 0 )
@@ -190,6 +184,16 @@
         return( ret );
     }
 
+    ctx->K1 = mbedtls_calloc( cipher_info->block_size, sizeof( unsigned char ) );
+    ctx->K2 = mbedtls_calloc( cipher_info->block_size, sizeof( unsigned char ) );
+
+    if( ctx->K1 == NULL || ctx->K2 == NULL )
+    {
+        mbedtls_free(ctx->K1);
+        mbedtls_free(ctx->K2);
+        return( MBEDTLS_ERR_CMAC_ALLOC_FAILED );
+    }
+
     return( cmac_generate_subkeys( ctx ) );
 }