commit 2d730c015eedd6e1721ef15653b27a6c0cd0553b
author David Horstmann <david.horstmann@arm.com> Thu Nov 16 20:12:17 2023 +0000
committer David Horstmann <david.horstmann@arm.com> Wed Nov 22 15:07:31 2023 +0000
tree 8b19b4524de183a19fa365108a22b1e7de24a3e8
parent 0ee4d18bc6ca7d60b98f096b435f64b243edfb57

Compare buffers even for zero-length cases

This enables us to test that lengths are correctly zero when the buffer
pointer is NULL.

Signed-off-by: David Horstmann <david.horstmann@arm.com>

tests/suites/test_suite_psa_crypto_memory.function

diff --git a/tests/suites/test_suite_psa_crypto_memory.function b/tests/suites/test_suite_psa_crypto_memory.function
index e92cbb1..5938258 100644
--- a/tests/suites/test_suite_psa_crypto_memory.function
+++ b/tests/suites/test_suite_psa_crypto_memory.function
@@ -98,9 +98,9 @@
             TEST_ASSERT(input_copy.buffer == NULL);
         } else {
             TEST_ASSERT(input_copy.buffer != input);
-            TEST_MEMORY_COMPARE(input, input_len,
-                                input_copy.buffer, input_copy.len);
         }
+        TEST_MEMORY_COMPARE(input, input_len,
+                            input_copy.buffer, input_copy.len);
     }
 
 exit:
@@ -169,9 +169,8 @@
         TEST_ASSERT(output_copy.original == output);
         if (output == NULL) {
             TEST_ASSERT(output_copy.buffer == NULL);
-        } else {
-            TEST_EQUAL(output_copy.len, output_len);
         }
+        TEST_EQUAL(output_copy.len, output_len);
     }
 
 exit:
@@ -215,10 +214,8 @@
     if (exp_status == PSA_SUCCESS) {
         TEST_ASSERT(output_copy.buffer == NULL);
         TEST_EQUAL(output_copy.len, 0);
-        if (output != NULL) {
-            TEST_MEMORY_COMPARE(buffer_copy_for_comparison, output_len,
-                                output, output_len);
-        }
+        TEST_MEMORY_COMPARE(buffer_copy_for_comparison, output_len,
+                            output, output_len);
     }
 
 exit: