commit 2e9eef4f7b3939ac76b7c0790437b4a7bd6e1996
author Jack Lloyd <jack.lloyd@fortanix.com> Tue Jan 28 14:43:52 2020 -0500
committer Jack Lloyd <jack.lloyd@fortanix.com> Tue Jan 28 14:43:52 2020 -0500
tree 54e341ac84766b29c1dd702a8f83f6721ada7bab
parent 60239753d2c4d5b04984c971143037cc8ae03f97

Final review comments

library/pkparse.c

diff --git a/library/pkparse.c b/library/pkparse.c
index ac631d9..7df30fe 100644
--- a/library/pkparse.c
+++ b/library/pkparse.c
@@ -782,25 +782,17 @@
     */
 
     /* Import DP */
-    if( ( ret = mbedtls_asn1_get_tag( &p, end, &len,
-                                      MBEDTLS_ASN1_INTEGER ) ) != 0 ||
-        ( ret = mbedtls_mpi_read_binary( &rsa->DP, p, len ) ) != 0 )
-        goto cleanup;
-    p += len;
+    if( ( ret = mbedtls_asn1_get_mpi( &p, end, &rsa->DP ) ) != 0)
+       goto cleanup;
 
     /* Import DQ */
-    if( ( ret = mbedtls_asn1_get_tag( &p, end, &len,
-                                      MBEDTLS_ASN1_INTEGER ) ) != 0 ||
-        ( ret = mbedtls_mpi_read_binary( &rsa->DQ, p, len ) ) != 0 )
-        goto cleanup;
-    p += len;
+    if( ( ret = mbedtls_asn1_get_mpi( &p, end, &rsa->DQ ) ) != 0)
+       goto cleanup;
 
     /* Import QP */
-    if( ( ret = mbedtls_asn1_get_tag( &p, end, &len,
-                                      MBEDTLS_ASN1_INTEGER ) ) != 0 ||
-        ( ret = mbedtls_mpi_read_binary( &rsa->QP, p, len ) ) != 0 )
-        goto cleanup;
-    p += len;
+    if( ( ret = mbedtls_asn1_get_mpi( &p, end, &rsa->QP ) ) != 0)
+       goto cleanup;
+
 #else
     /* Verify existance of the CRT params */
     if( ( ret = mbedtls_asn1_get_mpi( &p, end, &T ) ) != 0 ||

library/rsa.c

diff --git a/library/rsa.c b/library/rsa.c
index dc34e38..6c45746 100644
--- a/library/rsa.c
+++ b/library/rsa.c
@@ -334,7 +334,7 @@
      */
 
 #if !defined(MBEDTLS_RSA_NO_CRT)
-    if( is_priv && !(have_DP && have_DQ && have_QP))
+    if( is_priv && ! ( have_DP && have_DQ && have_QP ) )
     {
         ret = mbedtls_rsa_deduce_crt( &ctx->P,  &ctx->Q,  &ctx->D,
                                       &ctx->DP, &ctx->DQ, &ctx->QP );