commit 3520fe6fda70f96cc0bf18c35648718601e87671
author Przemek Stekiel <przemyslaw.stekiel@mobica.com> Mon Jan 30 14:38:18 2023 +0100
committer Przemek Stekiel <przemyslaw.stekiel@mobica.com> Tue Apr 04 17:48:28 2023 +0200
tree d1193dfdef43fd76ff2b9fb44894f13b3efc30cd
parent 8a13866f6576570676cf5552e9c068509dafaa4b

Use MBEDTLS_ERROR_ADD() and tag macros

Signed-off-by: Przemek Stekiel <przemyslaw.stekiel@mobica.com>

library/x509_crt.c

diff --git a/library/x509_crt.c b/library/x509_crt.c
index 5e6409b..7389a9c 100644
--- a/library/x509_crt.c
+++ b/library/x509_crt.c
@@ -609,14 +609,15 @@
     }
 
     if (*p != end) {
-        return MBEDTLS_ERR_X509_INVALID_EXTENSIONS +
-               MBEDTLS_ERR_ASN1_LENGTH_MISMATCH;
+        return MBEDTLS_ERROR_ADD(MBEDTLS_ERR_X509_INVALID_EXTENSIONS,
+                                 MBEDTLS_ERR_ASN1_LENGTH_MISMATCH);
     }
 
     return 0;
 }
 
 /*
+ * SubjectAltName ::= GeneralNames
  * GeneralNames ::= SEQUENCE SIZE (1..MAX) OF GeneralName
  *
  * GeneralName ::= CHOICE {
@@ -677,8 +678,8 @@
             MBEDTLS_ASN1_CONTEXT_SPECIFIC) {
             if ((tag & (MBEDTLS_ASN1_CONSTRUCTED | MBEDTLS_ASN1_SEQUENCE)) !=
                 (MBEDTLS_ASN1_CONSTRUCTED | MBEDTLS_ASN1_SEQUENCE)) {
-                return MBEDTLS_ERR_X509_INVALID_EXTENSIONS +
-                       MBEDTLS_ERR_ASN1_UNEXPECTED_TAG;
+                return MBEDTLS_ERROR_ADD(MBEDTLS_ERR_X509_INVALID_EXTENSIONS,
+                                         MBEDTLS_ERR_ASN1_UNEXPECTED_TAG);
             }
         }
 
@@ -746,7 +747,7 @@
     size_t len = 0u;
 
     if ((ret = mbedtls_asn1_get_tag(p, end, &len,
-                                    MBEDTLS_ASN1_CONSTRUCTED | MBEDTLS_ASN1_SEQUENCE | 0)) != 0) {
+                                    MBEDTLS_ASN1_CONSTRUCTED | MBEDTLS_ASN1_SEQUENCE)) != 0) {
         return ret;
     }
 
@@ -768,13 +769,14 @@
         /* Getting authorityCertIssuer using the required specific class tag [1] */
         if ((ret = mbedtls_asn1_get_tag(p, end, &len,
                                         MBEDTLS_ASN1_CONTEXT_SPECIFIC | MBEDTLS_ASN1_CONSTRUCTED |
-                                        1)) != 0) {
+                                        MBEDTLS_X509_SAN_RFC822_NAME)) != 0) {
             /* authorityCertIssuer is an OPTIONAL field */
         } else {
             /* Getting directoryName using the required specific class tag [4] */
             if ((ret = mbedtls_asn1_get_tag(p, end, &len,
                                             MBEDTLS_ASN1_CONTEXT_SPECIFIC |
-                                            MBEDTLS_ASN1_CONSTRUCTED | 4)) != 0) {
+                                            MBEDTLS_ASN1_CONSTRUCTED |
+                                            MBEDTLS_X509_SAN_DIRECTORY_NAME)) != 0) {
                 return ret;
             } else {
                 /* "end" also includes the CertSerialNumber field so "len" shall be used */