commit 3e3fc91c33d985f806ea336accec1fe3e1ec1b44
author Janos Follath <janos.follath@arm.com> Thu Nov 24 18:02:46 2022 +0000
committer Janos Follath <janos.follath@arm.com> Fri Nov 25 17:55:00 2022 +0000
tree 5179a9107ec3fa1d796a135887c87185d743395c
parent d3eed3370902b84213118f533f512464da01d691

Bignum Mod: pass endianness as a parameter

The external representation before included more than just endianness
(like reading in Mongtomery curve scalars or converting hashes to
numbers in a standard compliant way).

These are higher level concepts and are out of scope for Bignum and for
the modulus structure.

Passing endianness as a parameter is a step towards removing it from the
modulus structure.

Signed-off-by: Janos Follath <janos.follath@arm.com>

library/bignum_mod.c

diff --git a/library/bignum_mod.c b/library/bignum_mod.c
index 4303efe..fa4831c 100644
--- a/library/bignum_mod.c
+++ b/library/bignum_mod.c
@@ -212,7 +212,8 @@
 int mbedtls_mpi_mod_read( mbedtls_mpi_mod_residue *r,
                           const mbedtls_mpi_mod_modulus *m,
                           const unsigned char *buf,
-                          size_t buflen )
+                          size_t buflen,
+                          mbedtls_mpi_mod_ext_rep ext_rep )
 {
     int ret = MBEDTLS_ERR_MPI_BAD_INPUT_DATA;
 
@@ -223,7 +224,7 @@
          r->limbs == 0 || m->limbs == 0 )
         goto cleanup;
 
-    ret = mbedtls_mpi_mod_raw_read( r->p, m, buf, buflen );
+    ret = mbedtls_mpi_mod_raw_read( r->p, m, buf, buflen, ext_rep );
 
     if( ret != 0 )
         goto cleanup;
@@ -240,7 +241,8 @@
 int mbedtls_mpi_mod_write( const mbedtls_mpi_mod_residue *r,
                            const mbedtls_mpi_mod_modulus *m,
                            unsigned char *buf,
-                           size_t buflen )
+                           size_t buflen,
+                           mbedtls_mpi_mod_ext_rep ext_rep )
 {
     int ret = MBEDTLS_ERR_MPI_BAD_INPUT_DATA;
 
@@ -254,7 +256,7 @@
     if ( m->int_rep == MBEDTLS_MPI_MOD_REP_MONTGOMERY)
         ret = mbedtls_mpi_mod_raw_from_mont_rep( r->p, m );
 
-    ret = mbedtls_mpi_mod_raw_write( r->p, m, buf, buflen );
+    ret = mbedtls_mpi_mod_raw_write( r->p, m, buf, buflen, ext_rep );
 
 cleanup:
     return ( ret );