commit 3fe2abf306d2d2a50af22ba4ac96649be800c278
author Dave Rodgman <dave.rodgman@arm.com> Fri Mar 10 17:05:54 2023 +0000
committer Dave Rodgman <dave.rodgman@arm.com> Sun Mar 12 08:50:58 2023 +0000
tree 3b142c84f9729ebb56630b0cda009209faf6feb2
parent d12b592bc1e0c019917d5cc6d6e58754a2f20e3d

Apply suggestions from code review

Co-authored-by: Tom Cosgrove <tom.cosgrove@arm.com>
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>

ChangeLog.d/pkcs7-parser.txt

diff --git a/ChangeLog.d/pkcs7-parser.txt b/ChangeLog.d/pkcs7-parser.txt
index a988e95..ac477b1 100644
--- a/ChangeLog.d/pkcs7-parser.txt
+++ b/ChangeLog.d/pkcs7-parser.txt
@@ -1,15 +1,15 @@
 Features
-   * Added partial support for parsing the PKCS #7 cryptographic message
-     syntax, as defined in RFC 2315. Currently, support is limited to the
+   * Added partial support for parsing the PKCS #7 Cryptographic Message
+     Syntax, as defined in RFC 2315. Currently, support is limited to the
      following:
-     - Only the signed data content type, version 1 is supported.
+     - Only the signed-data content type, version 1 is supported.
      - Only DER encoding is supported.
      - Only a single digest algorithm per message is supported.
      - Only 0 or 1 certificates are supported per message, which must be in
        X.509 format.
-     - There is no support for certificate-revocation lists.
+     - There is no support for certificate revocation lists.
      - The authenticated and unauthenticated attribute fields of SignerInfo
        must be empty.
      Many thanks to Daniel Axtens, Nayna Jain, and Nick Child from IBM for
      contributing this feature. Thanks to Demi-Marie Obenour for contributing
-     various improvements, tests and bug-fixes.
+     various improvements, tests and bug fixes.

include/mbedtls/mbedtls_config.h

diff --git a/include/mbedtls/mbedtls_config.h b/include/mbedtls/mbedtls_config.h
index 63649f4..ffc216e 100644
--- a/include/mbedtls/mbedtls_config.h
+++ b/include/mbedtls/mbedtls_config.h
@@ -2862,7 +2862,7 @@
 /**
  * \def MBEDTLS_PKCS7_C
  *
- * Enable PKCS7 core for using PKCS7 formatted signatures.
+ * Enable PKCS #7 core for using PKCS #7-formatted signatures.
  * RFC Link - https://tools.ietf.org/html/rfc2315
  *
  * Module:  library/pkcs7.c

include/mbedtls/pkcs7.h

diff --git a/include/mbedtls/pkcs7.h b/include/mbedtls/pkcs7.h
index 7f2aa9e..cf1555c 100644
--- a/include/mbedtls/pkcs7.h
+++ b/include/mbedtls/pkcs7.h
@@ -22,8 +22,8 @@
  */
 
 /**
- * Note: For the time being, this implementation of the PKCS #7 cryptographic
- * message syntax is a partial implementation of RFC 2315.
+ * Note: For the time being, this implementation of the PKCS #7 Cryptographic
+ * Message Syntax is a partial implementation of RFC 2315.
  * Differences include:
  *  - The RFC specifies 6 different content types. The only type currently
  *    supported in Mbed TLS is the signed data content type.