commit 48ec2c7b5e77b5c7e0057d1218eb7ef4f989b87e
author Manuel Pégourié-Gonnard <mpg2@elzevir.fr> Wed Sep 30 16:30:28 2015 +0200
committer Manuel Pégourié-Gonnard <mpg2@elzevir.fr> Thu Oct 01 10:07:28 2015 +0200
tree 336979053f2edbaa293592624950a594b968aa72
parent 5aff029f9d2b8db78da64655c6808a1dfac6f64f

Fix potential overflow in base64_encode

library/base64.c

diff --git a/library/base64.c b/library/base64.c
index 2f7bb14..c743511 100644
--- a/library/base64.c
+++ b/library/base64.c
@@ -91,15 +91,16 @@
         return( 0 );
     }
 
-    n = ( slen << 3 ) / 6;
+    n = slen / 3 + ( slen % 3 != 0 );
 
-    switch( ( slen << 3 ) - ( n * 6 ) )
+    if( n > ( SIZE_T_MAX - 1 ) / 4 )
     {
-        case  2: n += 3; break;
-        case  4: n += 2; break;
-        default: break;
+        *dlen = SIZE_T_MAX;
+        return( POLARSSL_ERR_BASE64_BUFFER_TOO_SMALL );
     }
 
+    n *= 4;
+
     if( *dlen < n + 1 )
     {
         *dlen = n + 1;