commit 4abc32734e231ad4c06c29eb6c627623a0a0e8fb
author Manuel Pégourié-Gonnard <mpg@elzevir.fr> Wed Sep 10 12:02:46 2014 +0000
committer Paul Bakker <p.j.bakker@polarssl.org> Tue Oct 21 16:30:29 2014 +0200
tree 798653dea7143f35f773688547e0a22ecd61c859
parent f899583f948c04f1a5f8691f0123749789124c66

No memmove: ssl_parse_finished()

library/ssl_tls.c

diff --git a/library/ssl_tls.c b/library/ssl_tls.c
index 08b26b3..b43acaa 100644
--- a/library/ssl_tls.c
+++ b/library/ssl_tls.c
@@ -3791,8 +3791,6 @@
         return( ret );
     }
 
-    ssl_hs_rm_dtls_hdr( ssl );
-
     if( ssl->in_msgtype != SSL_MSG_HANDSHAKE )
     {
         SSL_DEBUG_MSG( 1, ( "bad finished message" ) );
@@ -3803,13 +3801,14 @@
     hash_len = ( ssl->minor_ver == SSL_MINOR_VERSION_0 ) ? 36 : 12;
 
     if( ssl->in_msg[0] != SSL_HS_FINISHED ||
-        ssl->in_hslen  != 4 + hash_len )
+        ssl->in_hslen  != ssl_hs_hdr_len( ssl ) + hash_len )
     {
         SSL_DEBUG_MSG( 1, ( "bad finished message" ) );
         return( POLARSSL_ERR_SSL_BAD_HS_FINISHED );
     }
 
-    if( safer_memcmp( ssl->in_msg + 4, buf, hash_len ) != 0 )
+    if( safer_memcmp( ssl->in_msg + ssl_hs_hdr_len( ssl ),
+                      buf, hash_len ) != 0 )
     {
         SSL_DEBUG_MSG( 1, ( "bad finished message" ) );
         return( POLARSSL_ERR_SSL_BAD_HS_FINISHED );