commit 4ed836883ea8e6a49d1fe18691b4fc658b63858a
author Ronald Cron <ronald.cron@arm.com> Fri Jun 18 14:51:29 2021 +0200
committer Ronald Cron <ronald.cron@arm.com> Tue Jun 22 13:43:13 2021 +0200
tree ea4f31ed90713b92404c3ad59d829ee0b8b8c9bb
parent ef0d8f17f813867c7ab5dbd9f128d812d0017dfe

psa: mac: Add driver delegation support for psa_mac_verify()

Signed-off-by: Ronald Cron <ronald.cron@arm.com>

library/psa_crypto.c

diff --git a/library/psa_crypto.c b/library/psa_crypto.c
index 07f52f3..775923a 100644
--- a/library/psa_crypto.c
+++ b/library/psa_crypto.c
@@ -2596,25 +2596,29 @@
                              size_t mac_length)
 {
     psa_status_t status = PSA_ERROR_CORRUPTION_DETECTED;
-    psa_mac_operation_t operation = PSA_MAC_OPERATION_INIT;
+    uint8_t actual_mac[PSA_MAC_MAX_SIZE];
+    size_t actual_mac_length;
 
-    status = psa_mac_verify_setup( &operation, key, alg );
+    status = psa_mac_compute_internal( key, alg,
+                                       input, input_length,
+                                       actual_mac, sizeof( actual_mac ),
+                                       &actual_mac_length, 0 );
     if( status != PSA_SUCCESS )
         goto exit;
 
-    status = psa_mac_update( &operation, input, input_length );
-    if( status != PSA_SUCCESS )
+    if( mac_length != actual_mac_length )
+    {
+        status = PSA_ERROR_INVALID_SIGNATURE;
         goto exit;
-
-    status = psa_mac_verify_finish( &operation, mac, mac_length );
-    if( status != PSA_SUCCESS )
+    }
+    if( mbedtls_psa_safer_memcmp( mac, actual_mac, actual_mac_length ) != 0 )
+    {
+        status = PSA_ERROR_INVALID_SIGNATURE;
         goto exit;
+    }
 
 exit:
-    if ( status == PSA_SUCCESS )
-        status = psa_mac_abort( &operation );
-    else
-        psa_mac_abort( &operation );
+    mbedtls_platform_zeroize( actual_mac, sizeof( actual_mac ) );
 
     return ( status );
 }