commit 4f2cd95e1d1a371d4be84030d26ca2c1863b1878
author Manuel Pégourié-Gonnard <mpg2@elzevir.fr> Wed Aug 12 11:17:55 2015 +0200
committer Manuel Pégourié-Gonnard <mpg2@elzevir.fr> Mon Sep 07 12:43:09 2015 +0200
tree 964bc5ea10af683ca77dd7fb01929fe7aab3568f
parent b1b250b68c63fca582cd5990e1ad42cb9ad76241

Fix potential memory leaks

library/ecjpake.c

diff --git a/library/ecjpake.c b/library/ecjpake.c
index 57afb45..19f964f 100644
--- a/library/ecjpake.c
+++ b/library/ecjpake.c
@@ -160,7 +160,10 @@
 
     len = mbedtls_mpi_size( &h ); /* actually r */
     if( end < *p || (size_t)( end - *p ) < 1 + len || len > 255 )
-        return( MBEDTLS_ERR_ECP_BUFFER_TOO_SMALL );
+    {
+        ret = MBEDTLS_ERR_ECP_BUFFER_TOO_SMALL;
+        goto cleanup;
+    }
 
     *(*p)++ = (unsigned char)( len & 0xFF );
     MBEDTLS_MPI_CHK( mbedtls_mpi_write_binary( &h, *p, len ) ); /* r */
@@ -208,11 +211,17 @@
                      (const unsigned char **) p, end - *p ) );
 
     if( end < *p || (size_t)( end - *p ) < 1 )
-        return( MBEDTLS_ERR_ECP_BAD_INPUT_DATA );
+    {
+        ret = MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
+        goto cleanup;
+    }
 
     r_len = *(*p)++;
     if( end < *p || (size_t)( end - *p ) < r_len )
-        return( MBEDTLS_ERR_ECP_BAD_INPUT_DATA );
+    {
+        ret = MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
+        goto cleanup;
+    }
 
     MBEDTLS_MPI_CHK( mbedtls_mpi_read_binary( &r, *p, r_len ) );
     *p += r_len;
@@ -225,7 +234,10 @@
                      &VV, &h, X, &r, G ) );
 
     if( mbedtls_ecp_point_cmp( &VV, &V ) != 0 )
-        return( MBEDTLS_ERR_ECP_VERIFY_FAILED );
+    {
+        ret = MBEDTLS_ERR_ECP_VERIFY_FAILED;
+        goto cleanup;
+    }
 
 cleanup:
     mbedtls_ecp_point_free( &V );