commit 4f5eb7cb5411fea304a10f1eadaa9ddeded16395
author mohammad1603 <mohammad.abomokh@arm.com> Mon Apr 30 17:23:47 2018 +0300
committer itayzafrir <itay.zafrir@arm.com> Wed Sep 05 12:38:18 2018 +0300
tree cf83e68489b48f4d3a02f2c12203ca118cc4b6f9
parent 6bbd8c75dcf1460bb499c8ba4037309a0817350f

Fill the the output buffer with zero data in case of failure

library/psa_crypto.c

diff --git a/library/psa_crypto.c b/library/psa_crypto.c
index 7589432..0ed9dd9 100755
--- a/library/psa_crypto.c
+++ b/library/psa_crypto.c
@@ -1528,6 +1528,7 @@
         if( ret != 0 )
         {
             mbedtls_gcm_free( &gcm );
+            mbedtls_zeroize( ciphertext, plaintext_length );
             return( mbedtls_to_psa_error( ret ) );
         }
 
@@ -1554,6 +1555,7 @@
         if( ret != 0 )
         {
             mbedtls_ccm_free( &ccm );
+            mbedtls_zeroize( ciphertext, plaintext_length );
             return( mbedtls_to_psa_error( ret ) );
         }
 
@@ -1622,6 +1624,7 @@
         if( ret != 0 )
         {
             mbedtls_gcm_free( &gcm );
+            mbedtls_zeroize( plaintext, ciphertext_length );
             return( mbedtls_to_psa_error( ret ) );
         }
 
@@ -1649,14 +1652,14 @@
         if( ret != 0 )
         {
             mbedtls_ccm_free( &ccm );
+            mbedtls_zeroize( plaintext, ciphertext_length );
             return( mbedtls_to_psa_error( ret ) );
         }
 
         mbedtls_ccm_free( &ccm );
     }
 
-    memcpy( plaintext + ciphertext_length, tag, sizeof( tag ) );
-    *plaintext_length = ciphertext_length + sizeof( tag );
+    *plaintext_length = ciphertext_length;
     return( PSA_SUCCESS );
 }