commit 4fcc61eec055dc8451c348f850e207796c765eea
author Przemek Stekiel <przemyslaw.stekiel@mobica.com> Tue Feb 14 20:05:43 2023 +0100
committer Przemek Stekiel <przemyslaw.stekiel@mobica.com> Wed Feb 22 11:30:32 2023 +0100
tree 0411acb84a947d27a717a37bbc6061cb4ff63c9a
parent 849c35f8b469f8ec4fed0b7c2d6db2ea9c799ddd

Optimize psa_pake_ecjpake_setup()

Signed-off-by: Przemek Stekiel <przemyslaw.stekiel@mobica.com>

library/psa_crypto_pake.c

diff --git a/library/psa_crypto_pake.c b/library/psa_crypto_pake.c
index 10691af..2d84f57 100644
--- a/library/psa_crypto_pake.c
+++ b/library/psa_crypto_pake.c
@@ -167,19 +167,10 @@
 static psa_status_t psa_pake_ecjpake_setup(mbedtls_psa_pake_operation_t *operation)
 {
     int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
-    mbedtls_ecjpake_role role;
+    mbedtls_ecjpake_role role = (operation->role == PSA_PAKE_ROLE_CLIENT) ?
+        MBEDTLS_ECJPAKE_CLIENT : MBEDTLS_ECJPAKE_SERVER;
 
-    if (operation->role == PSA_PAKE_ROLE_CLIENT) {
-        role = MBEDTLS_ECJPAKE_CLIENT;
-    } else if (operation->role == PSA_PAKE_ROLE_SERVER) {
-        role = MBEDTLS_ECJPAKE_SERVER;
-    } else {
-        return PSA_ERROR_BAD_STATE;
-    }
-
-    if (operation->password_len == 0) {
-        return PSA_ERROR_BAD_STATE;
-    }
+    mbedtls_ecjpake_init(&operation->ctx.pake);
 
     ret = mbedtls_ecjpake_setup(&operation->ctx.pake,
                                 role,
@@ -189,9 +180,6 @@
                                 operation->password_len);
 
     mbedtls_platform_zeroize(operation->password, operation->password_len);
-    mbedtls_free(operation->password);
-    operation->password = NULL;
-    operation->password_len = 0;
 
     if (ret != 0) {
         return mbedtls_ecjpake_to_psa_error(ret);
@@ -238,7 +226,7 @@
             return PSA_ERROR_NOT_SUPPORTED;
         }
 
-        mbedtls_ecjpake_init(&operation->ctx.pake);
+
 
         operation->password = mbedtls_calloc(1, password_len);
         if (operation->password == NULL) {