commit 55ceff6d2f48000d979c3e335816b6cf36b297fb
author Przemek Stekiel <przemyslaw.stekiel@mobica.com> Fri Mar 10 12:40:41 2023 +0100
committer Przemek Stekiel <przemyslaw.stekiel@mobica.com> Fri Mar 10 14:36:16 2023 +0100
tree f75af4cf9a4e44abf0ebc347b03d50c5c24b30b5
parent 89e268dfb93c40af19f1c712225371f6154a8e53

Code optimization and style fixes

Signed-off-by: Przemek Stekiel <przemyslaw.stekiel@mobica.com>

library/x509write_csr.c

diff --git a/library/x509write_csr.c b/library/x509write_csr.c
index a830fc2..deb6617 100644
--- a/library/x509write_csr.c
+++ b/library/x509write_csr.c
@@ -97,7 +97,7 @@
     size_t buflen = 0;
 
     /* Determine the maximum size of the SubjectAltName list */
-    for(cur = san_list; cur != NULL; cur = cur->next) {
+    for (cur = san_list; cur != NULL; cur = cur->next) {
         /* Calculate size of the required buffer */
         switch (cur->node.type) {
             case MBEDTLS_X509_SAN_DNS_NAME:
@@ -136,17 +136,23 @@
             case MBEDTLS_X509_SAN_DNS_NAME:
             case MBEDTLS_X509_SAN_UNIFORM_RESOURCE_IDENTIFIER:
             case MBEDTLS_X509_SAN_IP_ADDRESS:
+            {
+                const unsigned char *unstructured_name =
+                    (const unsigned char *) cur->node.san.unstructured_name.p;
+                size_t unstructured_name_len = cur->node.san.unstructured_name.len;
+
                 MBEDTLS_ASN1_CHK_CLEANUP_ADD(len,
-                                             mbedtls_asn1_write_raw_buffer(&p, buf,
-                                                                           (const unsigned char *) cur->node.san.unstructured_name.p,
-                                                                           cur->node.san.unstructured_name.len));
-                MBEDTLS_ASN1_CHK_CLEANUP_ADD(len, mbedtls_asn1_write_len(&p, buf,
-                                                                         cur->node.san.unstructured_name.len));
+                                             mbedtls_asn1_write_raw_buffer(
+                                                 &p, buf,
+                                                 unstructured_name, unstructured_name_len));
+                MBEDTLS_ASN1_CHK_CLEANUP_ADD(len, mbedtls_asn1_write_len(
+                                                 &p, buf, unstructured_name_len));
                 MBEDTLS_ASN1_CHK_CLEANUP_ADD(len,
-                                             mbedtls_asn1_write_tag(&p, buf,
-                                                                    MBEDTLS_ASN1_CONTEXT_SPECIFIC |
-                                                                    cur->node.type));
-                break;
+                                             mbedtls_asn1_write_tag(
+                                                 &p, buf,
+                                                 MBEDTLS_ASN1_CONTEXT_SPECIFIC | cur->node.type));
+            }
+            break;
             default:
                 /* Skip unsupported names. */
                 break;
@@ -170,7 +176,7 @@
 
     /* If we exceeded the allocated buffer it means that maximum size of the SubjectAltName list
      * was incorrectly calculated and memory is corrupted. */
-    if ( p < buf ) {
+    if (p < buf) {
         ret = MBEDTLS_ERR_ASN1_LENGTH_MISMATCH;
     }
 

programs/x509/cert_req.c

diff --git a/programs/x509/cert_req.c b/programs/x509/cert_req.c
index 8baca81..2f7126b 100644
--- a/programs/x509/cert_req.c
+++ b/programs/x509/cert_req.c
@@ -169,7 +169,6 @@
     mbedtls_ctr_drbg_context ctr_drbg;
     const char *pers = "csr example app";
     mbedtls_x509_san_list *cur, *prev;
-    uint8_t ip[4];
 
     /*
      * Set to sane values
@@ -220,6 +219,8 @@
             prev = NULL;
 
             while (q != NULL) {
+                uint8_t ip[4] = { 0 };
+
                 if ((r = strchr(q, ';')) != NULL) {
                     *r++ = '\0';
                 }