commit 57501ef056585bd52988db296ceb17d09f6a4989
author Ron Eldor <Ron.Eldor@arm.com> Thu Jan 12 14:50:50 2017 +0200
committer Simon Butcher <simon.butcher@arm.com> Thu Jul 20 01:26:53 2017 +0200
tree 5548bdc8a5718ff737b3d0efa60ddc402da5fe57
parent 454da1fa6f61d4229ed8da34a3711ad04b74fcf7

Backport 1.3: Check rc of mbedtls_mpi_fill_random

Add MPI_CHK to check for error value of mpi_fill_random.
Backport from Report and fix suggestion by guidovranken in #740

ChangeLog

diff --git a/ChangeLog b/ChangeLog
index 43ad0c3..081bcf1 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -11,6 +11,8 @@
    * Fix resource leak on windows platform, in mbedtls_x509_crt_parse_path.
      In case of failure, when an error occures, goto cleanup.
      Found by redplait #590
+   * Add MPI_CHK to check for error value of mpi_fill_random.
+     Backported from a report and fix suggestion by guidovranken in #740
 
 = mbed TLS 1.3.20 branch released 2017-06-21
 

library/dhm.c

diff --git a/library/dhm.c b/library/dhm.c
index 0a4f820..48fba2a 100644
--- a/library/dhm.c
+++ b/library/dhm.c
@@ -163,7 +163,7 @@
      */
     do
     {
-        mpi_fill_random( &ctx->X, x_size, f_rng, p_rng );
+        MPI_CHK( mpi_fill_random( &ctx->X, x_size, f_rng, p_rng ) );
 
         while( mpi_cmp_mpi( &ctx->X, &ctx->P ) >= 0 )
             MPI_CHK( mpi_shift_r( &ctx->X, 1 ) );
@@ -249,7 +249,7 @@
      */
     do
     {
-        mpi_fill_random( &ctx->X, x_size, f_rng, p_rng );
+        MPI_CHK( mpi_fill_random( &ctx->X, x_size, f_rng, p_rng ) );
 
         while( mpi_cmp_mpi( &ctx->X, &ctx->P ) >= 0 )
             MPI_CHK( mpi_shift_r( &ctx->X, 1 ) );
@@ -322,7 +322,7 @@
     count = 0;
     do
     {
-        mpi_fill_random( &ctx->Vi, mpi_size( &ctx->P ), f_rng, p_rng );
+        MPI_CHK( mpi_fill_random( &ctx->Vi, mpi_size( &ctx->P ), f_rng, p_rng ) );
 
         while( mpi_cmp_mpi( &ctx->Vi, &ctx->P ) >= 0 )
             MPI_CHK( mpi_shift_r( &ctx->Vi, 1 ) );

library/ecp.c

diff --git a/library/ecp.c b/library/ecp.c
index 796452b..79066dc 100644
--- a/library/ecp.c
+++ b/library/ecp.c
@@ -1151,7 +1151,7 @@
     /* Generate l such that 1 < l < p */
     do
     {
-        mpi_fill_random( &l, p_size, f_rng, p_rng );
+        MPI_CHK( mpi_fill_random( &l, p_size, f_rng, p_rng ) );
 
         while( mpi_cmp_mpi( &l, &grp->P ) >= 0 )
             MPI_CHK( mpi_shift_r( &l, 1 ) );
@@ -1536,7 +1536,7 @@
     /* Generate l such that 1 < l < p */
     do
     {
-        mpi_fill_random( &l, p_size, f_rng, p_rng );
+        MPI_CHK( mpi_fill_random( &l, p_size, f_rng, p_rng ) );
 
         while( mpi_cmp_mpi( &l, &grp->P ) >= 0 )
             MPI_CHK( mpi_shift_r( &l, 1 ) );