commit 596e014a06d9b3c9e3ad86231e1eb8c713b73bb3
author Hanno Becker <hanno.becker@arm.com> Tue Dec 18 15:00:38 2018 +0000
committer Hanno Becker <hanno.becker@arm.com> Tue Dec 18 16:31:06 2018 +0000
tree 6e068b0ba833e89196b4087c8c0880b1117ecb30
parent 230b4f415926c608e898b4b5879e278b8ecb90a1

Add validation is `is224` argument in mbedtls_sha256_starts_ret()

library/sha256.c

diff --git a/library/sha256.c b/library/sha256.c
index 5092091..8df4fb1 100644
--- a/library/sha256.c
+++ b/library/sha256.c
@@ -107,7 +107,8 @@
  */
 int mbedtls_sha256_starts_ret( mbedtls_sha256_context *ctx, int is224 )
 {
-    MBEDTLS_SHA256_VALIDATE( ctx != NULL );
+    MBEDTLS_SHA256_VALIDATE_RET( ctx != NULL );
+    MBEDTLS_SHA256_VALIDATE_RET( is224 == 0 || is224 == 1 );
 
     ctx->total[0] = 0;
     ctx->total[1] = 0;
@@ -277,12 +278,12 @@
     size_t fill;
     uint32_t left;
 
+    MBEDTLS_SHA256_VALIDATE_RET( ctx != NULL );
+    MBEDTLS_SHA256_VALIDATE_RET( ilen == 0 || input != NULL );
+
     if( ilen == 0 )
         return( 0 );
 
-    MBEDTLS_SHA256_VALIDATE_RET( ctx != NULL );
-    MBEDTLS_SHA256_VALIDATE_RET( input != NULL );
-
     left = ctx->total[0] & 0x3F;
     fill = 64 - left;
 
@@ -415,6 +416,7 @@
     int ret;
     mbedtls_sha256_context ctx;
 
+    MBEDTLS_SHA256_VALIDATE_RET( is224 == 0 || is224 == 1 );
     MBEDTLS_SHA256_VALIDATE_RET( ilen == 0 || input != NULL );
     MBEDTLS_SHA256_VALIDATE_RET( (unsigned char *)output != NULL );