commit 5c2665b1646e741d3ced9a111d62c091887cf38f
author Gilles Peskine <Gilles.Peskine@arm.com> Sun Feb 14 01:22:56 2021 +0100
committer Gilles Peskine <Gilles.Peskine@arm.com> Tue Feb 23 20:29:38 2021 +0100
tree c16990e3ce12a5517b4082e0d26450adc0b584a9
parent ad557e58bf2019872b15b782d21bae3073ed9fe1

Use const pointers on parsing functions

The const-ness has to be cast away when calling mbedtls_asn1_xxx
parsing functions. This is a known flaw in the mbedtls API
(https://github.com/ARMmbed/mbedtls/issues/803).

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>

tests/include/test/psa_exercise_key.h

diff --git a/tests/include/test/psa_exercise_key.h b/tests/include/test/psa_exercise_key.h
index 1c7eefc..1613237 100644
--- a/tests/include/test/psa_exercise_key.h
+++ b/tests/include/test/psa_exercise_key.h
@@ -143,8 +143,8 @@
     psa_key_derivation_operation_t* operation,
     mbedtls_svc_key_id_t key,
     psa_algorithm_t alg,
-    unsigned char* input1, size_t input1_length,
-    unsigned char* input2, size_t input2_length,
+    const unsigned char* input1, size_t input1_length,
+    const unsigned char* input2, size_t input2_length,
     size_t capacity );
 
 /** Perform a key agreement using the given key pair against its public key
@@ -198,7 +198,7 @@
  */
 int mbedtls_test_psa_exported_key_sanity_check(
     psa_key_type_t type, size_t bits,
-    uint8_t *exported, size_t exported_length );
+    const uint8_t *exported, size_t exported_length );
 
 /** Do smoke tests on a key.
  *

tests/src/psa_exercise_key.c

diff --git a/tests/src/psa_exercise_key.c b/tests/src/psa_exercise_key.c
index 11c6fcd..74cdc19 100644
--- a/tests/src/psa_exercise_key.c
+++ b/tests/src/psa_exercise_key.c
@@ -370,8 +370,8 @@
     psa_key_derivation_operation_t* operation,
     mbedtls_svc_key_id_t key,
     psa_algorithm_t alg,
-    unsigned char* input1, size_t input1_length,
-    unsigned char* input2, size_t input2_length,
+    const unsigned char* input1, size_t input1_length,
+    const unsigned char* input2, size_t input2_length,
     size_t capacity )
 {
     PSA_ASSERT( psa_key_derivation_setup( operation, alg ) );
@@ -576,7 +576,7 @@
 
 int mbedtls_test_psa_exported_key_sanity_check(
     psa_key_type_t type, size_t bits,
-    uint8_t *exported, size_t exported_length )
+    const uint8_t *exported, size_t exported_length )
 {
     if( PSA_KEY_TYPE_IS_UNSTRUCTURED( type ) )
         TEST_EQUAL( exported_length, ( bits + 7 ) / 8 );
@@ -606,8 +606,8 @@
 #if defined(MBEDTLS_RSA_C) && defined(MBEDTLS_PK_PARSE_C)
     if( type == PSA_KEY_TYPE_RSA_KEY_PAIR )
     {
-        uint8_t *p = exported;
-        uint8_t *end = exported + exported_length;
+        uint8_t *p = (uint8_t*) exported;
+        const uint8_t *end = exported + exported_length;
         size_t len;
         /*   RSAPrivateKey ::= SEQUENCE {
          *       version             INTEGER,  -- must be 0
@@ -662,8 +662,8 @@
 #if defined(MBEDTLS_RSA_C)
     if( type == PSA_KEY_TYPE_RSA_PUBLIC_KEY )
     {
-        uint8_t *p = exported;
-        uint8_t *end = exported + exported_length;
+        uint8_t *p = (uint8_t*) exported;
+        const uint8_t *end = exported + exported_length;
         size_t len;
         /*   RSAPublicKey ::= SEQUENCE {
          *      modulus            INTEGER,    -- n