commit 5c8434cf524d33a57c89bedd1a2ad2750b3a40c9
author Manuel Pégourié-Gonnard <mpg@elzevir.fr> Mon Oct 28 13:46:11 2013 +0100
committer Paul Bakker <p.j.bakker@polarssl.org> Mon Jul 07 14:10:07 2014 +0200
tree 335b8e3422eb99960482776ef28d111a9efbfc1f
parent 79f1ff84edc219a6b3506df93763583086322e5e

Safer buffer comparisons in the SSL modules

library/ssl_srv.c

diff --git a/library/ssl_srv.c b/library/ssl_srv.c
index d166986..ea1d63e 100644
--- a/library/ssl_srv.c
+++ b/library/ssl_srv.c
@@ -106,9 +106,11 @@
     }
     else
     {
+        /* Check verify-data in constant-time. The length OTOH is no secret */
         if( len    != 1 + ssl->verify_data_len ||
             buf[0] !=     ssl->verify_data_len ||
-            memcmp( buf + 1, ssl->peer_verify_data, ssl->verify_data_len ) != 0 )
+            safer_memcmp( buf + 1, ssl->peer_verify_data,
+                          ssl->verify_data_len ) != 0 )
         {
             SSL_DEBUG_MSG( 1, ( "non-matching renegotiated connection field" ) );