commit 5d164c4e2308dfd8185293c0a1996e2e12525b36
author Valerio Setti <vsetti@baylibre.com> Mon Jan 09 12:19:40 2023 +0100
committer Valerio Setti <vsetti@baylibre.com> Thu Jan 12 17:01:44 2023 +0100
tree 76a7730002d34c3b8152a479b0b5967dbb9bc054
parent 903b6aa87d868f21c3fa5aa100020907a2fa7ba9

fix: add missing deprecation guards

Signed-off-by: Valerio Setti <vsetti@baylibre.com>

include/mbedtls/x509_crt.h

diff --git a/include/mbedtls/x509_crt.h b/include/mbedtls/x509_crt.h
index f552345..810873c 100644
--- a/include/mbedtls/x509_crt.h
+++ b/include/mbedtls/x509_crt.h
@@ -987,7 +987,7 @@
  */
 void mbedtls_x509write_crt_set_version(mbedtls_x509write_cert *ctx, int version);
 
-#if defined(MBEDTLS_BIGNUM_C)
+#if defined(MBEDTLS_BIGNUM_C) && !defined(MBEDTLS_DEPRECATED_REMOVED)
 /**
  * \brief           Set the serial number for a Certificate.
  *
@@ -1005,8 +1005,9 @@
  *
  * \return          0 if successful
  */
-int mbedtls_x509write_crt_set_serial(mbedtls_x509write_cert *ctx, const mbedtls_mpi *serial);
-#endif
+int MBEDTLS_DEPRECATED mbedtls_x509write_crt_set_serial(
+    mbedtls_x509write_cert *ctx, const mbedtls_mpi *serial);
+#endif // MBEDTLS_BIGNUM_C && !MBEDTLS_DEPRECATED_REMOVED
 
 /**
  * \brief           Set the serial number for a Certificate.

library/x509write_crt.c

diff --git a/library/x509write_crt.c b/library/x509write_crt.c
index 53c2ac4..718b6f0 100644
--- a/library/x509write_crt.c
+++ b/library/x509write_crt.c
@@ -100,7 +100,7 @@
     return mbedtls_x509_string_to_names(&ctx->issuer, issuer_name);
 }
 
-#if defined(MBEDTLS_BIGNUM_C)
+#if defined(MBEDTLS_BIGNUM_C) && !defined(MBEDTLS_DEPRECATED_REMOVED)
 int mbedtls_x509write_crt_set_serial(mbedtls_x509write_cert *ctx,
                                      const mbedtls_mpi *serial)
 {
@@ -129,7 +129,7 @@
 
     return 0;
 }
-#endif
+#endif // MBEDTLS_BIGNUM_C && !MBEDTLS_DEPRECATED_REMOVED
 
 int mbedtls_x509write_crt_set_serial_new(mbedtls_x509write_cert *ctx,
                                          char *serial_buff, size_t serial_buff_len)

programs/x509/cert_write.c

diff --git a/programs/x509/cert_write.c b/programs/x509/cert_write.c
index 363ed8d..ec4d325 100644
--- a/programs/x509/cert_write.c
+++ b/programs/x509/cert_write.c
@@ -663,7 +663,7 @@
     mbedtls_x509write_crt_set_version(&crt, opt.version);
     mbedtls_x509write_crt_set_md_alg(&crt, opt.md);
 
-#if defined(MBEDTLS_BIGNUM_C)
+#if defined(MBEDTLS_BIGNUM_C) && !defined(MBEDTLS_DEPRECATED_REMOVED)
     ret = mbedtls_x509write_crt_set_serial(&crt, &serial);
     if (ret != 0) {
         mbedtls_strerror(ret, buf, sizeof(buf));

tests/suites/test_suite_x509write.function

diff --git a/tests/suites/test_suite_x509write.function b/tests/suites/test_suite_x509write.function
index 2bf8024..e09c4c5 100644
--- a/tests/suites/test_suite_x509write.function
+++ b/tests/suites/test_suite_x509write.function
@@ -384,15 +384,12 @@
         TEST_ASSERT(mbedtls_pk_get_type(&issuer_key) == MBEDTLS_PK_OPAQUE);
     }
 
-#if !defined(MBEDTLS_BIGNUM_C)
-    TEST_ASSERT(mbedtls_test_read_mpi(&serial, serial_str) == 0);
-#endif
-
     if (ver != -1) {
         mbedtls_x509write_crt_set_version(&crt, ver);
     }
 
-#if !defined(MBEDTLS_BIGNUM_C)
+#if defined(MBEDTLS_BIGNUM_C) && !defined(MBEDTLS_DEPRECATED_REMOVED)
+    TEST_ASSERT(mbedtls_test_read_mpi(&serial, serial_str) == 0);
     TEST_ASSERT(mbedtls_x509write_crt_set_serial(&crt, &serial) == 0);
 #else
     TEST_ASSERT(mbedtls_x509write_crt_set_serial_new(&crt, serial_str,