commit 5f0c6e82fb88049569b7d1f87f4cfd120c80c689
author Andrzej Kurek <andrzej.kurek@arm.com> Mon Feb 27 16:03:41 2023 -0500
committer Andrzej Kurek <andrzej.kurek@arm.com> Wed Mar 29 11:40:38 2023 -0400
tree b577a26b4f54eeeaf5d4e2b193a0eff915821b06
parent 532b8d41afb8e6c7fb80cdcb7b6a062f40bea035

Add missing deallocation of subject alt name

Since mbedtls_x509_get_name allocates memory
when parsing a directoryName, deallocation
has to be performed if anything fails in the
meantime.
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>

library/x509.c

diff --git a/library/x509.c b/library/x509.c
index 4b4e1b6..c9524c9 100644
--- a/library/x509.c
+++ b/library/x509.c
@@ -1590,10 +1590,15 @@
             case MBEDTLS_X509_SAN_DIRECTORY_NAME:
             {
                 ret = mbedtls_snprintf(p, n, "\n%s    directoryName : ", prefix);
+                if (ret < 0 || (size_t) ret >= n) {
+                    mbedtls_x509_free_subject_alt_name(&san);
+                }
+
                 MBEDTLS_X509_SAFE_SNPRINTF;
                 ret = mbedtls_x509_dn_gets(p, n, &san.san.directory_name);
 
                 if (ret < 0) {
+                    mbedtls_x509_free_subject_alt_name(&san);
                     return ret;
                 }
 
@@ -1611,7 +1616,7 @@
         }
 
         /* So far memory is freed only in the case of directoryName
-         * parsing succeeding, as mbedtls_x509_dn_gets allocates memory. */
+         * parsing succeeding, as mbedtls_x509_get_name allocates memory. */
         mbedtls_x509_free_subject_alt_name(&san);
         cur = cur->next;
     }