commit 614faa26ac8e1fa978a34480013b3ae57c7f72fe
author Gilles Peskine <Gilles.Peskine@arm.com> Fri Jun 07 15:39:07 2019 +0200
committer Gilles Peskine <Gilles.Peskine@arm.com> Fri Jul 19 17:08:35 2019 +0200
tree a5e08809ba2f214bfd305e572bd503d17a0f52f7
parent 69c0ea26c74cbdb2adb6f48b2afb3d60c455f73c

Test PSA functions against PSA_SUCCESS, not 0

Writing 0 instead of PSA_SUCCESS is correct, but bad form.

tests/suites/test_suite_cipher.function

diff --git a/tests/suites/test_suite_cipher.function b/tests/suites/test_suite_cipher.function
index 1ea1408..209d8e4 100644
--- a/tests/suites/test_suite_cipher.function
+++ b/tests/suites/test_suite_cipher.function
@@ -982,7 +982,7 @@
 #else
     if( use_psa == 1 )
     {
-        TEST_ASSERT( psa_crypto_init() == 0 );
+        TEST_ASSERT( psa_crypto_init( ) == PSA_SUCCESS );
 
         /* PSA requires that the tag immediately follows the ciphertext. */
         tmp_cipher = mbedtls_calloc( 1, cipher->len + tag->len );
@@ -1143,7 +1143,7 @@
 #else
     if( use_psa == 1 )
     {
-        TEST_ASSERT( psa_crypto_init() == 0 );
+        TEST_ASSERT( psa_crypto_init( ) == PSA_SUCCESS );
         TEST_ASSERT( 0 == mbedtls_cipher_setup_psa( &ctx,
                               mbedtls_cipher_info_from_type( cipher_id ), 0 ) );
     }

tests/suites/test_suite_pk.function

diff --git a/tests/suites/test_suite_pk.function b/tests/suites/test_suite_pk.function
index 3282214..98c5a83 100644
--- a/tests/suites/test_suite_pk.function
+++ b/tests/suites/test_suite_pk.function
@@ -127,7 +127,7 @@
     mbedtls_pk_init( &pk );
     mbedtls_pk_init( &pk2 );
 
-    TEST_ASSERT( psa_crypto_init() == 0 );
+    TEST_ASSERT( psa_crypto_init( ) == PSA_SUCCESS );
 
     TEST_ASSERT( mbedtls_pk_setup_opaque( &pk, 0 ) ==
                  MBEDTLS_ERR_PK_BAD_INPUT_DATA );