commit 6692a064e3204188f686f36b62c1889ff9d58e90
author Jonas <jonas.lejeune4420@gmail.com> Fri May 08 16:57:18 2020 +0900
committer Jonas <jonas.lejeune4420@gmail.com> Fri May 08 16:58:47 2020 +0900
tree 1a95db188d1e78c75577098a14e319758dad35d5
parent 5435451a1a3d0af3eef71e3883f3087df52e48d5

Fix potential memory leak in EC multiplication

Signed-off-by: Jonas <jonas.lejeune4420@gmail.com>

library/ecp.c

diff --git a/library/ecp.c b/library/ecp.c
index 104e1f1..3c4a91a 100644
--- a/library/ecp.c
+++ b/library/ecp.c
@@ -1544,7 +1544,10 @@
             MBEDTLS_MPI_CHK( mbedtls_mpi_shift_r( &l, 1 ) );
 
         if( count++ > 10 )
-            return( MBEDTLS_ERR_ECP_RANDOM_FAILED );
+        {
+            ret = MBEDTLS_ERR_ECP_RANDOM_FAILED;
+            goto cleanup;
+        }
     }
     while( mbedtls_mpi_cmp_int( &l, 1 ) <= 0 );
 
@@ -2278,7 +2281,10 @@
             MBEDTLS_MPI_CHK( mbedtls_mpi_shift_r( &l, 1 ) );
 
         if( count++ > 10 )
-            return( MBEDTLS_ERR_ECP_RANDOM_FAILED );
+        {
+            ret = MBEDTLS_ERR_ECP_RANDOM_FAILED;
+            goto cleanup;
+        }
     }
     while( mbedtls_mpi_cmp_int( &l, 1 ) <= 0 );