commit 69cc6307506d3b6707857f05d894a4e8a6f895fa
author Ronald Cron <ronald.cron@arm.com> Wed Apr 01 15:52:06 2020 +0200
committer Ronald Cron <ronald.cron@arm.com> Mon Apr 06 11:58:27 2020 +0200
tree 73327fdca64040a201c407b7073ae6a81ed81dda
parent bde4d3045bff0a0e8b8880d5499bba850cd76bd4

unit tests: Fix potential buffer overflow

Fix potential buffer overflow when tracking the unmet dependencies
of a test case. The identifiers of unmet dependencies are stored
in an array of fixed size. Ensure that we don't overrun the array.

Signed-off-by: Ronald Cron <ronald.cron@arm.com>

tests/suites/host_test.function

diff --git a/tests/suites/host_test.function b/tests/suites/host_test.function
index b7b00ec..aff49ca 100644
--- a/tests/suites/host_test.function
+++ b/tests/suites/host_test.function
@@ -521,8 +521,12 @@
                     int dep_id = strtol( params[i], NULL, 10 );
                     if( dep_check( dep_id ) != DEPENDENCY_SUPPORTED )
                     {
-                        unmet_dependencies[unmet_dep_count] = dep_id;
-                        unmet_dep_count++;
+                        if( unmet_dep_count <
+                            ARRAY_LENGTH( unmet_dependencies ) )
+                        {
+                            unmet_dependencies[unmet_dep_count] = dep_id;
+                            unmet_dep_count++;
+                        }
                     }
                 }