commit 782a7eab14ca6f4c32da0ae779ada232cea0ba63
author TRodziewicz <tomasz.rodziewicz@mobica.com> Wed Mar 17 11:35:16 2021 +0100
committer TRodziewicz <tomasz.rodziewicz@mobica.com> Wed Mar 17 11:36:31 2021 +0100
tree d8f424ebfd4c309c889921b69b92aed70e29ac77
parent 9edff740e145d2cdaf7e870fcdd6b40c1aaec11e

ecjpake_zkp_read() now returns ...BAD_INPUT_DATA when r len == 0 and test follows that

Signed-off-by: TRodziewicz <tomasz.rodziewicz@mobica.com>

library/ecjpake.c

diff --git a/library/ecjpake.c b/library/ecjpake.c
index b835ac1..464ff51 100644
--- a/library/ecjpake.c
+++ b/library/ecjpake.c
@@ -273,7 +273,7 @@
 
     r_len = *(*p)++;
 
-    if( end < *p || (size_t)( end - *p ) < r_len )
+    if( end < *p || (size_t)( end - *p ) < r_len || r_len == 0 )
     {
         ret = MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
         goto cleanup;
@@ -286,13 +286,6 @@
      * Verification
      */
     MBEDTLS_MPI_CHK( ecjpake_hash( md_info, grp, pf, G, &V, X, id, &h ) );
-
-    if( mbedtls_mpi_cmp_int( &r,0 ) == 0 )
-    {
-        ret = MBEDTLS_ERR_ECP_INVALID_KEY;
-        goto cleanup;
-    }
-
     MBEDTLS_MPI_CHK( mbedtls_ecp_muladd( (mbedtls_ecp_group *) grp,
                      &VV, &h, X, &r, G ) );