commit 8061c6e894293bb09d6926470392144c1f383612
author Hanno Becker <hanno.becker@arm.com> Fri Jul 26 08:07:03 2019 +0100
committer Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com> Thu Aug 01 09:51:54 2019 +0200
tree 863dc91f63317b524b4a743094017572c12054f0
parent 7b5ba84624e57bfca0aaa8df63d0fee8b0ccb1a0

Don't use memcpy() for 2-byte copy operation

Manual copying is slightly shorter here.

library/ssl_tls.c

diff --git a/library/ssl_tls.c b/library/ssl_tls.c
index 47b1538..22ee6fc 100644
--- a/library/ssl_tls.c
+++ b/library/ssl_tls.c
@@ -4891,13 +4891,11 @@
      * Parse and validate record version
      */
 
-    memcpy( &rec->ver[0],
-            buf + rec_hdr_version_offset,
-            rec_hdr_version_len );
-
+    rec->ver[0] = buf[ rec_hdr_version_offset + 0 ];
+    rec->ver[1] = buf[ rec_hdr_version_offset + 1 ];
     mbedtls_ssl_read_version( &major_ver, &minor_ver,
                               ssl->conf->transport,
-                              buf + rec_hdr_version_offset );
+                              &rec->ver[0] );
 
     if( major_ver != mbedtls_ssl_get_major_ver( ssl ) )
     {