commit 818bac55ef59c2fdd5a3f5047977eb925aa567c4
author Hanno Becker <hanno.becker@arm.com> Fri Oct 26 09:13:26 2018 +0100
committer Simon Butcher <simon.butcher@arm.com> Tue Feb 19 17:59:57 2019 +0000
tree abffdef4fcf2240e55c2da48894025ada8c79a97
parent 996033e3dfce2900eca72c606fb7f3821f0a82f5

Add further missing brackets around macro parameters

library/aes.c

diff --git a/library/aes.c b/library/aes.c
index b2e346e..aff0a99 100644
--- a/library/aes.c
+++ b/library/aes.c
@@ -397,7 +397,7 @@
  */
 #define ROTL8(x) ( ( (x) << 8 ) & 0xFFFFFFFF ) | ( (x) >> 24 )
 #define XTIME(x) ( ( (x) << 1 ) ^ ( ( (x) & 0x80 ) ? 0x1B : 0x00 ) )
-#define MUL(x,y) ( ( (x) && (y) ) ? pow[(log[x]+log[y]) % 255] : 0 )
+#define MUL(x,y) ( ( (x) && (y) ) ? pow[(log[(x)]+log[(y)]) % 255] : 0 )
 
 static int aes_init_done = 0;
 

library/md4.c

diff --git a/library/md4.c b/library/md4.c
index 156e715..41c5d54 100644
--- a/library/md4.c
+++ b/library/md4.c
@@ -148,8 +148,8 @@
 #define P(a,b,c,d,x,s)         \
     do                         \
     {                          \
-        (a) += F(b,c,d) + (x); \
-        (a) = S(a,s);          \
+        (a) += F((b),(c),(d)) + (x);             \
+        (a) = S((a),(s));                        \
     } while( 0 )
 
 

library/md5.c

diff --git a/library/md5.c b/library/md5.c
index bdbb760..a93da8a 100644
--- a/library/md5.c
+++ b/library/md5.c
@@ -142,7 +142,7 @@
 #define P(a,b,c,d,k,s,t)                                        \
     do                                                          \
     {                                                           \
-        (a) += F((b),(c),(d)) + X[k] + (t);                     \
+        (a) += F((b),(c),(d)) + X[(k)] + (t);                   \
         (a) = S((a),(s)) + (b);                                 \
     } while( 0 )
 

library/sha1.c

diff --git a/library/sha1.c b/library/sha1.c
index 2f2946b..355c83d 100644
--- a/library/sha1.c
+++ b/library/sha1.c
@@ -164,8 +164,8 @@
 #define P(a,b,c,d,e,x)                                          \
     do                                                          \
     {                                                           \
-        (e) += S(a,5) + F(b,c,d) + K + (x);                     \
-        (b) = S(b,30);                                          \
+        (e) += S((a),5) + F((b),(c),(d)) + K + (x);             \
+        (b) = S((b),30);                                        \
     } while( 0 )
 
     A = ctx->state[0];

library/sha256.c

diff --git a/library/sha256.c b/library/sha256.c
index 09d3fe3..2dc0e1a 100644
--- a/library/sha256.c
+++ b/library/sha256.c
@@ -193,8 +193,8 @@
 #define P(a,b,c,d,e,f,g,h,x,K)                          \
     do                                                  \
     {                                                   \
-        temp1 = (h) + S3(e) + F1(e,f,g) + (K) + (x);    \
-        temp2 = S2(a) + F0(a,b,c);                      \
+        temp1 = (h) + S3(e) + F1((e),(f),(g)) + (K) + (x);      \
+        temp2 = S2(a) + F0((a),(b),(c));                        \
         (d) += temp1; (h) = temp1 + temp2;              \
     } while( 0 )
 

library/sha512.c

diff --git a/library/sha512.c b/library/sha512.c
index cec955b..efc4acb 100644
--- a/library/sha512.c
+++ b/library/sha512.c
@@ -239,8 +239,8 @@
 #define P(a,b,c,d,e,f,g,h,x,K)                          \
     do                                                  \
     {                                                   \
-        temp1 = (h) + S3(e) + F1(e,f,g) + (K) + (x);    \
-        temp2 = S2(a) + F0(a,b,c);                      \
+        temp1 = (h) + S3(e) + F1((e),(f),(g)) + (K) + (x);      \
+        temp2 = S2(a) + F0((a),(b),(c));                        \
         (d) += temp1; (h) = temp1 + temp2;              \
     } while( 0 )