commit 849c35f8b469f8ec4fed0b7c2d6db2ea9c799ddd
author Przemek Stekiel <przemyslaw.stekiel@mobica.com> Tue Feb 14 15:11:40 2023 +0100
committer Przemek Stekiel <przemyslaw.stekiel@mobica.com> Wed Feb 22 11:30:32 2023 +0100
tree 4198e0d00568e1aa3cc486ab7dc0b330cc367e0c
parent e1d51bf3c9f47f5a8325db7d00448a3c458fa1b8

Remove pake abort on failure from driver (handled by core)

Signed-off-by: Przemek Stekiel <przemyslaw.stekiel@mobica.com>

library/psa_crypto_pake.c

diff --git a/library/psa_crypto_pake.c b/library/psa_crypto_pake.c
index 1a7725f..10691af 100644
--- a/library/psa_crypto_pake.c
+++ b/library/psa_crypto_pake.c
@@ -230,14 +230,12 @@
             cipher_suite.family != PSA_ECC_FAMILY_SECP_R1 ||
             cipher_suite.bits != 256 ||
             cipher_suite.hash != PSA_ALG_SHA_256) {
-            status = PSA_ERROR_NOT_SUPPORTED;
-            goto error;
+            return PSA_ERROR_NOT_SUPPORTED;
         }
 
         if (role != PSA_PAKE_ROLE_CLIENT &&
             role != PSA_PAKE_ROLE_SERVER) {
-            status = PSA_ERROR_NOT_SUPPORTED;
-            goto error;
+            return PSA_ERROR_NOT_SUPPORTED;
         }
 
         mbedtls_ecjpake_init(&operation->ctx.pake);
@@ -245,13 +243,13 @@
         operation->password = mbedtls_calloc(1, password_len);
         if (operation->password == NULL) {
             status = PSA_ERROR_INSUFFICIENT_MEMORY;
-            goto error;
+            return status;
         }
 
         status = psa_crypto_driver_pake_get_password(inputs, operation->password,
                                                      password_len, &actual_password_len);
         if (status != PSA_SUCCESS) {
-            goto error;
+            return status;
         }
 
         operation->password_len = actual_password_len;
@@ -265,7 +263,7 @@
         status = psa_pake_ecjpake_setup(operation);
 
         if (status != PSA_SUCCESS) {
-            goto error;
+            return status;
         }
 
         return PSA_SUCCESS;
@@ -276,8 +274,6 @@
 #endif
     { status = PSA_ERROR_NOT_SUPPORTED; }
 
-error:
-    mbedtls_psa_pake_abort(operation);
     return status;
 }
 
@@ -399,10 +395,6 @@
     psa_status_t status = mbedtls_psa_pake_output_internal(
         operation, step, output, output_size, output_length);
 
-    if (status != PSA_SUCCESS) {
-        mbedtls_psa_pake_abort(operation);
-    }
-
     return status;
 }
 
@@ -506,10 +498,6 @@
     psa_status_t status = mbedtls_psa_pake_input_internal(
         operation, step, input, input_length);
 
-    if (status != PSA_SUCCESS) {
-        mbedtls_psa_pake_abort(operation);
-    }
-
     return status;
 }
 
@@ -528,7 +516,6 @@
                                                mbedtls_psa_get_random,
                                                MBEDTLS_PSA_RANDOM_STATE);
         if (ret != 0) {
-            mbedtls_psa_pake_abort(operation);
             return mbedtls_ecjpake_to_psa_error(ret);
         }
 
@@ -537,8 +524,6 @@
 
         mbedtls_platform_zeroize(operation->buffer, MBEDTLS_PSA_PAKE_BUFFER_SIZE);
 
-        mbedtls_psa_pake_abort(operation);
-
         return PSA_SUCCESS;
     } else
 #else